From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Angus Gardner <angusg778@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Removed unnecessary parenthesis around conditions to comply with the checkpatch coding style.
Date: Wed, 13 Sep 2023 08:32:20 +0700 [thread overview]
Message-ID: <ZQERJIGOOeYxgX3E@debian.me> (raw)
In-Reply-To: <ZQEKFR1OPoXGI2lO@midnight>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Wed, Sep 13, 2023 at 11:02:13AM +1000, Angus Gardner wrote:
> ---
> drivers/staging/fbtft/fb_ra8875.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
No patch description and SoB, so Greg can't take this as-is.
> - if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) {
> + if (par->info->var.xres == 320 && par->info->var.yres == 240) {
Greg prefers explicit parentheses on complex expressions (see [1] and [2]
for examples), hence NAK.
Thanks.
[1]: https://lore.kernel.org/linux-staging/ZCWGOZqdH1kWtOEq@kroah.com/
[2]: https://lore.kernel.org/linux-staging/Y%2FiaYtKk4VSokAFz@kroah.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-13 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 1:02 [PATCH] staging: fbtft: Removed unnecessary parenthesis around conditions to comply with the checkpatch coding style Angus Gardner
2023-09-13 1:32 ` Bagas Sanjaya [this message]
[not found] ` <CAC5tM5u8L50fAhReAmP0dqexSmv-PdZJKa_ES2hxZMp41MJjGQ@mail.gmail.com>
2023-09-15 7:56 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQERJIGOOeYxgX3E@debian.me \
--to=bagasdotme@gmail.com \
--cc=angusg778@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).