From: Dorcas Litunya <anonolitunya@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy@lists.linux.dev,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E
Date: Mon, 16 Oct 2023 23:29:47 +0300 [thread overview]
Message-ID: <ZS2dO4oirsQlM+TU@dorcaslitunya-virtual-machine> (raw)
In-Reply-To: <d4fb378f-7446-cf16-2d14-3623e313d6ac@inria.fr>
On Sun, Oct 15, 2023 at 10:22:29PM +0200, Julia Lawall wrote:
>
>
> On Sun, 15 Oct 2023, Dorcas AnonoLitunya wrote:
>
> > Rename function displayControlAdjust_SM750E to
> > display_control_adjust_SM750E.This follows snakecase naming convention
> > and ensures consistent naming style throughout the file.Issue by
> > checkpatch.
>
> The period at the end of a sentence should have a space after it.
>
> ensures -> ensures a
>
> Issue -> Issue found
>
This is corrected. Thanks Julia!
> julia
>
> >
> > Mutes the following error:
> > CHECK:Avoid CamelCase: <displayControlAdjust_SM750E>
> >
> > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> > index e00a6cb31947..8708995f676c 100644
> > --- a/drivers/staging/sm750fb/ddk750_mode.c
> > +++ b/drivers/staging/sm750fb/ddk750_mode.c
> > @@ -14,8 +14,8 @@
> > * in bit 29:27 of Display Control register.
> > */
> > static unsigned long
> > -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> > - unsigned long dispControl)
> > +display_control_adjust_SM750LE(struct mode_parameter *pModeParam,
> > + unsigned long dispControl)
> > {
> > unsigned long x, y;
> >
> > @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
> > tmp |= DISPLAY_CTRL_HSYNC_PHASE;
> >
> > if (sm750_get_chip_type() == SM750LE) {
> > - displayControlAdjust_SM750LE(pModeParam, tmp);
> > + display_control_adjust_SM750LE(pModeParam, tmp);
> > } else {
> > reg = peek32(CRT_DISPLAY_CTRL) &
> > ~(DISPLAY_CTRL_VSYNC_PHASE |
> > --
> > 2.42.0.345.gaab89be2eb
> >
> >
> >
next prev parent reply other threads:[~2023-10-16 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 20:12 [PATCH 0/5] staging: sm750fb: Renaming camelcase to snakecase Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E Dorcas AnonoLitunya
2023-10-15 20:22 ` Julia Lawall
2023-10-16 20:29 ` Dorcas Litunya [this message]
2023-10-15 20:12 ` [PATCH 2/5] Staging: sm750fb: Rename pModeParam Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 3/5] Staging: sm750fb: Rename displayControl Dorcas AnonoLitunya
2023-10-15 20:23 ` Julia Lawall
2023-10-16 20:30 ` Dorcas Litunya
2023-10-15 20:12 ` [PATCH 4/5] Staging: sm750fb: Rename programModeRegisters Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 5/5] Staging: sm750fb: Rename ddk750_setModeTiming Dorcas AnonoLitunya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS2dO4oirsQlM+TU@dorcaslitunya-virtual-machine \
--to=anonolitunya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox