From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Sahaj Sarup" <sahaj.sarup@linaro.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Helge Deller" <deller@gmx.de>, "Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value
Date: Fri, 17 Nov 2023 23:15:17 +0200 [thread overview]
Message-ID: <ZVfX5Tw71cqKFJ83@smile.fi.intel.com> (raw)
In-Reply-To: <20231116180743.2763021-2-javierm@redhat.com>
On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote:
> This is used to specify the page start address offset of the display RAM.
>
> The value is used as offset when setting the page start address with the
> SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to
> 1 if the property is not present in the Device Tree.
>
> But the datasheet mentions that the value on reset for the page start is a
> 0, so it makes more sense to also have 0 as the default value for the page
> offset if the property is not present.
>
> In fact, using a default value of 1 leads to the display not working when
> the fbdev is attached to the framebuffer console.
>
> Reported-by: Sahaj Sarup <sahaj.sarup@linaro.org>
Closes?
Fixes?
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-17 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231116180743.2763021-1-javierm@redhat.com>
2023-11-16 18:07 ` [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value Javier Martinez Canillas
2023-11-17 21:15 ` Andy Shevchenko [this message]
2023-11-17 22:18 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVfX5Tw71cqKFJ83@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sahaj.sarup@linaro.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox