Re: [BUG][BISECTED] Freeze at loading init ramdisk

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 8676 bytes --]

On Wed, Jan 17, 2024 at 07:47:49PM +0100, Mirsad Todorovac wrote:
> On 1/16/24 01:32, Mirsad Todorovac wrote:
> > Hi,
> > 
> > On the Ubuntu 22.04 LTS Jammy platform, on a mainline vanilla torvalds tree kernel, the boot
> > freezes upon first two lines and before any systemd messages.
> > 
> > (Please find the config attached.)
> > 
> > Bisecting the bug led to this result:
> > 
> > marvin@defiant:~/linux/kernel/linux_torvalds$ git bisect good
> > d97a78423c33f68ca6543de510a409167baed6f5 is the first bad commit
> > commit d97a78423c33f68ca6543de510a409167baed6f5
> > Merge: 61da593f4458 689237ab37c5
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date:   Fri Jan 12 14:38:08 2024 -0800
> > 
> >      Merge tag 'fbdev-for-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev
> >      Pull fbdev updates from Helge Deller:
> >       "Three fbdev drivers (~8500 lines of code) removed. The Carillo Ranch
> >        fbdev driver is for an Intel product which was never shipped, and for
> >        the intelfb and the amba-clcd drivers the drm drivers can be used
> >        instead.
> >        The other code changes are minor: some fb_deferred_io flushing fixes,
> >        imxfb margin fixes and stifb cleanups.
> >        Summary:
> >         - Remove intelfb fbdev driver (Thomas Zimmermann)
> >         - Remove amba-clcd fbdev driver (Linus Walleij)
> >         - Remove vmlfb Carillo Ranch fbdev driver (Matthew Wilcox)
> >         - fb_deferred_io flushing fixes (Nam Cao)
> >         - imxfb code fixes and cleanups (Dario Binacchi)
> >         - stifb primary screen detection cleanups (Thomas Zimmermann)"
> >      * tag 'fbdev-for-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev: (28 commits)
> >        fbdev/intelfb: Remove driver
> >        fbdev/hyperv_fb: Do not clear global screen_info
> >        firmware/sysfb: Clear screen_info state after consuming it
> >        fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers
> >        drm/hyperv: Remove firmware framebuffers with aperture helper
> >        fbdev/sis: Remove dependency on screen_info
> >        video/logo: use %u format specifier for unsigned int values
> >        video/sticore: Remove info field from STI struct
> >        arch/parisc: Detect primary video device from device instance
> >        fbdev/stifb: Allocate fb_info instance with framebuffer_alloc()
> >        video/sticore: Store ROM device in STI struct
> >        fbdev: flush deferred IO before closing
> >        fbdev: flush deferred work in fb_deferred_io_fsync()
> >        fbdev: amba-clcd: Delete the old CLCD driver
> >        fbdev: Remove support for Carillo Ranch driver
> >        fbdev: hgafb: fix kernel-doc comments
> >        fbdev: mmp: Fix typo and wording in code comment
> >        fbdev: fsl-diu-fb: Fix sparse warning due to virt_to_phys() prototype change
> >        fbdev: imxfb: add '*/' on a separate line in block comment
> >        fbdev: imxfb: use __func__ for function name
> >        ...
> > 
> >   Documentation/fb/index.rst                         |    1 -
> >   Documentation/fb/intelfb.rst                       |  155 --
> >   Documentation/userspace-api/ioctl/ioctl-number.rst |    1 -
> >   MAINTAINERS                                        |   12 -
> >   arch/parisc/video/fbdev.c                          |    2 +-
> >   drivers/Makefile                                   |    3 +-
> >   drivers/firmware/sysfb.c                           |   14 +-
> >   drivers/gpu/drm/hyperv/hyperv_drm_drv.c            |    8 +-
> >   drivers/video/backlight/Kconfig                    |    7 -
> >   drivers/video/backlight/Makefile                   |    1 -
> >   drivers/video/backlight/cr_bllcd.c                 |  264 ---
> >   drivers/video/fbdev/Kconfig                        |   72 -
> >   drivers/video/fbdev/Makefile                       |    2 -
> >   drivers/video/fbdev/amba-clcd.c                    |  986 ---------
> >   drivers/video/fbdev/core/fb_defio.c                |    8 +-
> >   drivers/video/fbdev/fsl-diu-fb.c                   |    2 +-
> >   drivers/video/fbdev/hgafb.c                        |   13 +-
> >   drivers/video/fbdev/hyperv_fb.c                    |   20 +-
> >   drivers/video/fbdev/imxfb.c                        |  179 +-
> >   drivers/video/fbdev/intelfb/Makefile               |    8 -
> >   drivers/video/fbdev/intelfb/intelfb.h              |  382 ----
> >   drivers/video/fbdev/intelfb/intelfb_i2c.c          |  209 --
> >   drivers/video/fbdev/intelfb/intelfbdrv.c           | 1680 ----------------
> >   drivers/video/fbdev/intelfb/intelfbhw.c            | 2115 --------------------
> >   drivers/video/fbdev/intelfb/intelfbhw.h            |  609 ------
> >   drivers/video/fbdev/mmp/hw/mmp_spi.c               |    2 +-
> >   drivers/video/fbdev/sis/sis_main.c                 |   37 -
> >   drivers/video/fbdev/stifb.c                        |  109 +-
> >   drivers/video/fbdev/vermilion/Makefile             |    6 -
> >   drivers/video/fbdev/vermilion/cr_pll.c             |  195 --
> >   drivers/video/fbdev/vermilion/vermilion.c          | 1175 -----------
> >   drivers/video/fbdev/vermilion/vermilion.h          |  245 ---
> >   drivers/video/logo/pnmtologo.c                     |    6 +-
> >   drivers/video/sticore.c                            |    5 +
> >   include/linux/amba/clcd-regs.h                     |   87 -
> >   include/linux/amba/clcd.h                          |  290 ---
> >   include/video/sticore.h                            |    6 +-
> >   37 files changed, 208 insertions(+), 8708 deletions(-)
> >   delete mode 100644 Documentation/fb/intelfb.rst
> >   delete mode 100644 drivers/video/backlight/cr_bllcd.c
> >   delete mode 100644 drivers/video/fbdev/amba-clcd.c
> >   delete mode 100644 drivers/video/fbdev/intelfb/Makefile
> >   delete mode 100644 drivers/video/fbdev/intelfb/intelfb.h
> >   delete mode 100644 drivers/video/fbdev/intelfb/intelfb_i2c.c
> >   delete mode 100644 drivers/video/fbdev/intelfb/intelfbdrv.c
> >   delete mode 100644 drivers/video/fbdev/intelfb/intelfbhw.c
> >   delete mode 100644 drivers/video/fbdev/intelfb/intelfbhw.h
> >   delete mode 100644 drivers/video/fbdev/vermilion/Makefile
> >   delete mode 100644 drivers/video/fbdev/vermilion/cr_pll.c
> >   delete mode 100644 drivers/video/fbdev/vermilion/vermilion.c
> >   delete mode 100644 drivers/video/fbdev/vermilion/vermilion.h
> >   delete mode 100644 include/linux/amba/clcd-regs.h
> >   delete mode 100644 include/linux/amba/clcd.h
> > marvin@defiant:~/linux/kernel/linux_torvalds$
> > 
> > Hope this helps.
> 
> P.S.
> 
> As I see that this is a larger merge commit, with 5K+ lines changed, I don't think I can
> bisect further to determine the culprit.
> 
> But I thought later that it would be interesting to see why my hardware triggered the freeze
> and probably others did not, or someone would complain already.
> 
> Both of the boxes were AMD Ryzen: Ryzen 7 5700G and Ryzen 9 7950X.
> 
> FWIW, I am attaching both hardware listings and the config used, so anyone knowledgeable with
> fbdev could possibly narrow down the search.
> 

Hi Mirsad,

There is another report from Jens with similar symptom [1]. Can you check if
reverting df67699c9cb0ce ("firmware/sysfb: Clear screen_info state after
consuming it") fixes your regression?

Thanks.

[1]: https://lore.kernel.org/regressions/93ffd2ee-fa83-4469-96fb-fb263c26bb3c@kernel.dk/T/#t


-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]