* [PATCH] staging: sm750fb: rename function deGetTransparency()
@ 2024-02-23 14:58 Samuel Kayode
2024-03-05 14:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Kayode @ 2024-02-23 14:58 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman, linux-fbdev,
linux-staging, linux-kernel
Rename function deGetTransparency to de_get_transparency to fix
checkpatch warning Avoid CamelCase.
Signed-off-by: Samuel Kayode <samkay014@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 44b9e3fe3a41..ad9d8bd34e5a 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
return 0;
}
-static unsigned int deGetTransparency(struct lynx_accel *accel)
+static unsigned int de_get_transparency(struct lynx_accel *accel)
{
unsigned int de_ctrl;
@@ -391,7 +391,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf,
DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE |
DE_CONTROL_HOST | DE_CONTROL_STATUS;
- write_dpr(accel, DE_CONTROL, de_ctrl | deGetTransparency(accel));
+ write_dpr(accel, DE_CONTROL, de_ctrl | de_get_transparency(accel));
/* Write MONO data (line by line) to 2D Engine data port */
for (i = 0; i < height; i++) {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: sm750fb: rename function deGetTransparency()
2024-02-23 14:58 [PATCH] staging: sm750fb: rename function deGetTransparency() Samuel Kayode
@ 2024-03-05 14:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-03-05 14:01 UTC (permalink / raw)
To: Samuel Kayode
Cc: Sudip Mukherjee, Teddy Wang, linux-fbdev, linux-staging,
linux-kernel
On Fri, Feb 23, 2024 at 10:58:12AM -0400, Samuel Kayode wrote:
> Rename function deGetTransparency to de_get_transparency to fix
> checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Samuel Kayode <samkay014@gmail.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..ad9d8bd34e5a 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
> return 0;
> }
>
> -static unsigned int deGetTransparency(struct lynx_accel *accel)
> +static unsigned int de_get_transparency(struct lynx_accel *accel)
What does "de_" here mean? Why did you keep it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-05 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 14:58 [PATCH] staging: sm750fb: rename function deGetTransparency() Samuel Kayode
2024-03-05 14:01 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).