From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rick L. Vinyard, Jr." Date: Fri, 08 Jan 2010 16:50:33 +0000 Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.3 Message-Id: List-Id: References: <201001071623.o07GNOB4022157@mustang.cs.nmsu.edu> <20100108083020.GB3696@core.coreip.homeip.net> <20100108163655.GA8328@elf.ucw.cz> In-Reply-To: <20100108163655.GA8328@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pavel Machek Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org, felipe.balbi@nokia.com, jayakumar.lkml@gmail.com, linux-fbdev@vger.kernel.org, krzysztof.h1@wp.pl, akpm@linux-foundation.org, linux-usb@vger.kernel.org, oliver@neukum.org, linux-input@vger.kernel.org, jkosina@suse.cz Pavel Machek wrote: > Hi! > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); >> >> What this attribute is for? > > Actually, all the new files this added need to be documented. > Pavel > Which is better? A hid-g13.txt file added to Documentation/ or comments in the driver itself? Thanks, --- Rick