From: Simona Vetter <simona.vetter@ffwll.ch>
To: oushixiong1025@163.com
Cc: Simona Vetter <simona@ffwll.ch>, Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Shixiong Ou <oushixiong@kylinos.cn>
Subject: Re: [PATCH] fbcon: Fix outdated registered_fb reference in comment
Date: Wed, 9 Jul 2025 15:29:16 +0200 [thread overview]
Message-ID: <aG5urDySjLCCj86J@phenom.ffwll.local> (raw)
In-Reply-To: <20250709103438.572309-1-oushixiong1025@163.com>
On Wed, Jul 09, 2025 at 06:34:38PM +0800, oushixiong1025@163.com wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> The variable was renamed to fbcon_registered_fb, but this comment was
> not updated along with the change. Correct it to avoid confusion.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
I've added the right Fixes: line and merged this to drm-misc-next, thanks
for your patch.
-Sima
> ---
> drivers/video/fbdev/core/fbcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 25684f5d6523..d8eab4859fd4 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -953,13 +953,13 @@ static const char *fbcon_startup(void)
> int rows, cols;
>
> /*
> - * If num_registered_fb is zero, this is a call for the dummy part.
> + * If fbcon_num_registered_fb is zero, this is a call for the dummy part.
> * The frame buffer devices weren't initialized yet.
> */
> if (!fbcon_num_registered_fb || info_idx == -1)
> return display_desc;
> /*
> - * Instead of blindly using registered_fb[0], we use info_idx, set by
> + * Instead of blindly using fbcon_registered_fb[0], we use info_idx, set by
> * fbcon_fb_registered();
> */
> info = fbcon_registered_fb[info_idx];
> --
> 2.25.1
>
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2025-07-09 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 10:34 [PATCH] fbcon: Fix outdated registered_fb reference in comment oushixiong1025
2025-07-09 13:29 ` Simona Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG5urDySjLCCj86J@phenom.ffwll.local \
--to=simona.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oushixiong1025@163.com \
--cc=oushixiong@kylinos.cn \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).