* [PATCH] fbcon: Fix outdated registered_fb reference in comment
@ 2025-07-09 10:34 oushixiong1025
2025-07-09 13:29 ` Simona Vetter
0 siblings, 1 reply; 2+ messages in thread
From: oushixiong1025 @ 2025-07-09 10:34 UTC (permalink / raw)
To: Simona Vetter
Cc: Helge Deller, linux-fbdev, dri-devel, linux-kernel, Shixiong Ou
From: Shixiong Ou <oushixiong@kylinos.cn>
The variable was renamed to fbcon_registered_fb, but this comment was
not updated along with the change. Correct it to avoid confusion.
Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
---
drivers/video/fbdev/core/fbcon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 25684f5d6523..d8eab4859fd4 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -953,13 +953,13 @@ static const char *fbcon_startup(void)
int rows, cols;
/*
- * If num_registered_fb is zero, this is a call for the dummy part.
+ * If fbcon_num_registered_fb is zero, this is a call for the dummy part.
* The frame buffer devices weren't initialized yet.
*/
if (!fbcon_num_registered_fb || info_idx == -1)
return display_desc;
/*
- * Instead of blindly using registered_fb[0], we use info_idx, set by
+ * Instead of blindly using fbcon_registered_fb[0], we use info_idx, set by
* fbcon_fb_registered();
*/
info = fbcon_registered_fb[info_idx];
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbcon: Fix outdated registered_fb reference in comment
2025-07-09 10:34 [PATCH] fbcon: Fix outdated registered_fb reference in comment oushixiong1025
@ 2025-07-09 13:29 ` Simona Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Simona Vetter @ 2025-07-09 13:29 UTC (permalink / raw)
To: oushixiong1025
Cc: Simona Vetter, Helge Deller, linux-fbdev, dri-devel, linux-kernel,
Shixiong Ou
On Wed, Jul 09, 2025 at 06:34:38PM +0800, oushixiong1025@163.com wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> The variable was renamed to fbcon_registered_fb, but this comment was
> not updated along with the change. Correct it to avoid confusion.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
I've added the right Fixes: line and merged this to drm-misc-next, thanks
for your patch.
-Sima
> ---
> drivers/video/fbdev/core/fbcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 25684f5d6523..d8eab4859fd4 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -953,13 +953,13 @@ static const char *fbcon_startup(void)
> int rows, cols;
>
> /*
> - * If num_registered_fb is zero, this is a call for the dummy part.
> + * If fbcon_num_registered_fb is zero, this is a call for the dummy part.
> * The frame buffer devices weren't initialized yet.
> */
> if (!fbcon_num_registered_fb || info_idx == -1)
> return display_desc;
> /*
> - * Instead of blindly using registered_fb[0], we use info_idx, set by
> + * Instead of blindly using fbcon_registered_fb[0], we use info_idx, set by
> * fbcon_fb_registered();
> */
> info = fbcon_registered_fb[info_idx];
> --
> 2.25.1
>
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-09 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09 10:34 [PATCH] fbcon: Fix outdated registered_fb reference in comment oushixiong1025
2025-07-09 13:29 ` Simona Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).