From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2482E7BB1 for ; Fri, 22 Aug 2025 07:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755847258; cv=none; b=oY2B1ciERwRC+havLHvBB5F0Q/ZQNaRlQGhCtFeQ3D9iT4fnLTLw1jMOXACQRzgGv2AS02/LCbRmwB8GlZyAUO2KW89zmocb1p0Sstay8bbTU4S5xR0L0itKAy6buUjionaIjPqPW6BKyHzvNuISsHVKiOVhIXbWvnYbcCtyjms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755847258; c=relaxed/simple; bh=Wqi2mO2fmQYFGAwZhuS4EvTXv9c8e4vGOynXydsCYEg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZiQf+ORRR8Ua5DGYjhbTWMY1r6laqvRsxldZp3nJrHwxwlLfWZyKOf8EbNuQqGmsbS00FvzGKidBgs6lcmwp49hpidl75Z9xvD/Jqb6s0epWt7rUxRZuR0xewwzlhxTmcvBpw61lVld1RCRgfxcZcqa4gH/BREJdUC7ct6zPbbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=CzrCEgtp; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="CzrCEgtp" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3c68ac7e18aso18235f8f.2 for ; Fri, 22 Aug 2025 00:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1755847254; x=1756452054; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IvJwbcOsjvAx4Cb95HKEUrId4UgDZ83tfHPDy6XNbLM=; b=CzrCEgtpdoGkqnoFgd3BDRMQ2P/eQhCKG4Z0wkSUWcnLPt1vgcTCwf9zdi6p2aBpn8 VL1Pwp52zWpuBdNhKhgTgRVKmkCSbU/9DNoleP+RBHNhZdW9XSVosePCGKsFvgQR+LL1 2sDzg3Iub364w8hWEyuPXhF4CYwMK8tiuqW+X2KccwWuE0FHvxLDpAUTwiTYmjv1TwBw Rysft3BvN4jEh2qSjaZ97wcE7EMngwGILnucCnRNhJkqgQGxFt6ox/d2oIN1zfzfqahV nI4VviJ6iWybgjVU9uI0SzAFZkcToWpjpXmnlJoxSjLuRCgLaOK9IiH52C399oVODUzZ jmdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755847254; x=1756452054; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IvJwbcOsjvAx4Cb95HKEUrId4UgDZ83tfHPDy6XNbLM=; b=sa06kNdNYzBv5n/JlmJtI73/WyEGLMVP408VnuoEY19mryy2VNqh8bPUsSDCo2YPX5 U4v8Zfm82xuEU5TXCjx5QMgEozi/7orldqWnYgfOTLK0Q3JwgUSUdzhlnB6UHxe9MQzQ qFcZ9TmQP+inPhgOWaRvPr/1c1Tb4GaXqvVGwpCqddYYnMqRjRRZONTZ5vtbGgqCIwGp kIFVxtJu2S9+J1pucljZ6MMZfeCjHMHQbkydH8r8wLGK9ZulG8cmZ2M3v8FSnI6by0J6 1WHT62m60E0tglnLXZtgtpC5niDbAIMxeluRzy3tqMwqCvSObWJEG3Fp7N0bP1mVeQnO ZRuw== X-Forwarded-Encrypted: i=1; AJvYcCX82E00MAmiu8B+ZN3hOipDmzYRqFHKjif1JclYn4GulUAX8YKTZIOuOkg40JQDqzW8fDf3mhBClfOlSg==@vger.kernel.org X-Gm-Message-State: AOJu0YzxrwqxepTnItOfcavdbx6zXIBYnEd6LX+pgOZtRF/+xgHiOL+v +NpWXex9Wz4pfWcr5DMtHnK6H2ikBSoJPkJGVMgRNUqyy2DtD+IaJyWOZQj1xZKmT2U= X-Gm-Gg: ASbGncvBhNsT5zH4YwOhnguGkVqy9yezsiPChpfUx+egewrLeH6uGd9XRYZ4h47R8gX DH2Fhd3MKJORDNc3jVcNT2ZWYLJFNRBPVqXfCwK4jGheyTzYI9SECX+P9yOOJPIwJ2V10ShZDIL izTUDTC5o5FAVYfWm6BvseE0BF2K/bCTsxF/gzVWmN9UAlQwVEUJ8eJv0qVZ0mJvy0fDtd6g3ji efUXySMFDHWu6s8KKIgxwIQOkSLyr7AMQaI1bEPvBAi9IhDBc8cdGbShBFnj7q8wbAkj2CF5ZLe gC3BS6i8RrBHAgS+ZXrCdJwywiOEeq0zhxRilqnRvhNTE+VnJp52NTmhFSdARGvcdmFjyPj23gc iLOInoW9IRs61pPFJSCuCrkdYYz7r0TayWmS5F92u2PdT2s2nHXot02RjhNptsp6dn/0oI95YQI RP7Ha8Vg== X-Google-Smtp-Source: AGHT+IFLbHL5Jfp1HiEMgBzb/cWVZllJl0fqqVCyRz90kU9u6d+rKWlXzqxgMmKXZyGMMiOGZn0oyA== X-Received: by 2002:a5d:5f4e:0:b0:3c0:7e02:67b9 with SMTP id ffacd0b85a97d-3c5dcefeda4mr1234311f8f.61.1755847253747; Fri, 22 Aug 2025 00:20:53 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c077c576b7sm14060427f8f.63.2025.08.22.00.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 00:20:53 -0700 (PDT) Date: Fri, 22 Aug 2025 08:20:50 +0100 From: Daniel Thompson To: maudspierings@gocontroll.com Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, MaudSpieringsmaudspierings@gocontroll.com Subject: Re: [PATCH v2 2/4] backlight: add max25014atg backlight Message-ID: References: <20250819-max25014-v2-0-5fd7aeb141ea@gocontroll.com> <20250819-max25014-v2-2-5fd7aeb141ea@gocontroll.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250819-max25014-v2-2-5fd7aeb141ea@gocontroll.com> On Tue, Aug 19, 2025 at 12:59:00PM +0200, Maud Spierings via B4 Relay wrote: > From: Maud Spierings > > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC > with intgrated boost controller. > > Signed-off-by: Maud Spierings maudspierings@gocontroll.com Looking good but still a few small comments (below). > diff --git a/drivers/video/backlight/max25014.c b/drivers/video/backlight/max25014.c > new file mode 100644 > index 0000000000000000000000000000000000000000..fe5e0615cf6d151868b56ebb9544b175b09dfcee > --- /dev/null > +++ b/drivers/video/backlight/max25014.c > @@ -0,0 +1,395 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Backlight driver for Maxim MAX25014 > + * > + * Copyright (C) 2025 GOcontroll B.V. > + * Author: Maud Spierings > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#define MAX25014_ISET_DEFAULT_100 11 > +#define MAX_BRIGHTNESS (100) > +#define MIN_BRIGHTNESS (0) > +#define TON_MAX (130720) /* @153Hz */ > +#define TON_STEP (1307) /* @153Hz */ > +#define TON_MIN (0) > + > +#define MAX25014_DEV_ID (0x00) > +#define MAX25014_REV_ID (0x01) > +#define MAX25014_ISET (0x02) > +#define MAX25014_IMODE (0x03) > +#define MAX25014_TON1H (0x04) > +#define MAX25014_TON1L (0x05) > +#define MAX25014_TON2H (0x06) > +#define MAX25014_TON2L (0x07) > +#define MAX25014_TON3H (0x08) > +#define MAX25014_TON3L (0x09) > +#define MAX25014_TON4H (0x0A) > +#define MAX25014_TON4L (0x0B) > +#define MAX25014_TON_1_4_LSB (0x0C) > +#define MAX25014_SETTING (0x12) > +#define MAX25014_DISABLE (0x13) > +#define MAX25014_BSTMON (0x14) > +#define MAX25014_IOUT1 (0x15) > +#define MAX25014_IOUT2 (0x16) > +#define MAX25014_IOUT3 (0x17) > +#define MAX25014_IOUT4 (0x18) > +#define MAX25014_OPEN (0x1B) > +#define MAX25014_SHORT_GND (0x1C) > +#define MAX25014_SHORT_LED (0x1D) > +#define MAX25014_MASK (0x1E) > +#define MAX25014_DIAG (0x1F) There is no need to put raw numbers in brackets. > + > +#define MAX25014_IMODE_HDIM BIT(2) > +#define MAX25014_ISET_ENABLE BIT(5) > +#define MAX25014_ISET_PSEN BIT(4) > +#define MAX25014_DIAG_HW_RST BIT(2) > +#define MAX25014_SETTING_FPWM GENMASK(6, 4) > + > +struct max25014 { > + struct i2c_client *client; > + struct backlight_device *bl; > + struct regmap *regmap; > + struct max25014_platform_data *pdata; This appears to be unused. > + struct gpio_desc *enable; > + struct regulator *vin; /* regulator for boost converter Vin rail */ > + uint32_t initial_brightness; It is important to keep the initial_brightness for the lifetime of the driver? > + uint32_t iset; > + uint8_t strings_mask; > +}; > + Daniel.