From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA6F2DC349 for ; Mon, 8 Dec 2025 10:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765190164; cv=none; b=FYQdxcOMiOsjVxEcr2bNyv6dkrkVKGw0SOedhS98WxmhRG96s7ZiwAIJtyEZjpGjcr4a6bceqFwA8fGstoR8E0XTZpW5e1seY7UBzSyjELOruFbodx/HX0Gi+1MAl6oFZNScCxeZOyGfXotEzZKrAq/aeyH6hh/662k84VNhQ10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765190164; c=relaxed/simple; bh=s0L/F0IMsYB37Rxo4CHT7apF8oSazdCraUwxwRSEMFw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RgJ0X8KcsDIauX3A17s2mZv06cYIs9CnOUCYaqsetrhNODNOgU4GhUPO33Bp2vXrokXpwNIpHIPgfucOCPlth7yg4IQPY1uZ2H1o7nWT41r8QiaYMN00sZ6wjSgdT1h4WFEVUBDh+A3VDQ/JkAbXth3y4OrdqKdSNI5rtDdsPMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=nMhn5PTL; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="nMhn5PTL" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so54842105e9.2 for ; Mon, 08 Dec 2025 02:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1765190159; x=1765794959; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+E3SOYkqsEc+5aDXpHHAZRqmKpJ7LXworventsdWgtI=; b=nMhn5PTL7mWngGMbeboSyi0dP4zWTcbikcsfwcPLTx5aKFoQ6YACS3xEp7I5wQDn19 8+2oMBb4KM3f7xm5TgP9iNxIw/2JGVRoGc/fIIAHZCJuKS2POcqde2W0oj0v2OJZXhry SGzWvtxeP2UNR1Ac3c0KW4Iy328FdcyzlRVD1YFVYiJpFajCmcYmS/YYa83/nJwGzhL5 taurYQskIYL4QueLkW7MvOdtVB/nOFF3a5YJUQMYQ/Qus+r3ic3+3YR3sdJ52y8CFwIw 1BF2mfTZdOGsRkm1dGNzEBa+ZtAMAKYlVhHE9DqtAcDBWxU6MWii/vchH0S8uzaWaY5x Ip6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765190159; x=1765794959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+E3SOYkqsEc+5aDXpHHAZRqmKpJ7LXworventsdWgtI=; b=Gny1nWOUXtVLwsmDZA1bQ0YqgPzSdPLgCR58MnrKIls7WnOzSnSyLsHagDhBVvoWy6 t8toN3xDm/oXHkj5PkcxN73guWcgXBkPw0RQ3xrCjYRfU9Lvb81Lyc12et2a6JoRaKyM ru8UDrHFDVsa8KkJie579AcN2PEVEBitxD7ddz/W/x0kXQezhxiFbZ+mzH8XLGpjnYY7 RPDfSpHiL8a92FCi3YIVOQJ9At9sNtB6L26MeizVhVQseDuc1CzxUTHA65aypu075pnM s6h5VEyzRqV+W5Dnds8tmE8YyNfBKpJZ+Vpnevwsy7mAvZ+xtpWLRv21dIZHEmf2H74m M35Q== X-Forwarded-Encrypted: i=1; AJvYcCXLKlkT4ivwpFLCQFSvTuaEyCamAVxRJmhnQ/qVL2N+LcAGwSm+v3ZL4Ndq/+1R0tjrwylH6kvFxNOhMw==@vger.kernel.org X-Gm-Message-State: AOJu0YzjtHOUnWeqYZwVsQ4IxB6JsSb7ZELETfRbfs8Epink3mVWzOc/ LVy3RlMs8dK31FCFB3OLbx87HfVqM+OivWokab6cK3us0VULL9oTYBP01vEU7qwtIww= X-Gm-Gg: ASbGncvCg/Ot03NQbFRryG63AeiJiMWjYXMjtWJ7MnFE7TL4IgKJBlAVgwGPnUrlkMv KXKRJXJ7VF6GnHYh6CJGM6Eddd8eNGGuCjv/EML9AKe4Aor7dFRtexhCF7N+gDrTUf30xXjirUo UFxfjv+cFajFjXwv+wJnkf0vukS+IqL/l/LyiKbElf/3Tu877qT/U5WVbwsXPchuLCObNaDoV5K TvO2Vz/bFk8k4J0ni6GJqsrjKvN6A/9y1l0Fr3MQhhbYkes5PobW+j7KpSpsjygES2MyT9HsZ+s vfGRbxzFCqYvfBVw5IJDDEi5+XMCkgcVW2Z5YnQwW2byS22hHXtcFnvU+j/dAA3+cJSQd5vnKni E0+wdHWZper8ZNTyEo/p9p+9VQtQKo5Nidbj5yvokhsMG/8jYRNtP1QkIdyiS4Mykmz19m0NXJ4 pZWkXqfQSip3OS959bsgiZQ8kzstwnUTGFcEGNse/MJyVjd0LcatxxsS1I9lGyzJu2AGFpeA== X-Google-Smtp-Source: AGHT+IGge21HXj48TLUzsA7ggUbHSFC0xO5HgqxGNKT4MTX7Oe0oV8kQd6FtV8OIYLtnHQGrRwLESw== X-Received: by 2002:a05:600c:818e:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-47939c87088mr76977635e9.0.1765190159388; Mon, 08 Dec 2025 02:35:59 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479311e712fsm240407865e9.9.2025.12.08.02.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Dec 2025 02:35:58 -0800 (PST) Date: Mon, 8 Dec 2025 10:35:55 +0000 From: Daniel Thompson To: Maud Spierings Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/4] backlight: add max25014atg backlight Message-ID: References: <20251201-max25014-v6-0-88e3ac8112ff@gocontroll.com> <20251201-max25014-v6-2-88e3ac8112ff@gocontroll.com> <8a9a59b8-d5c0-46b3-8f86-a4cd910b7af3@gocontroll.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a9a59b8-d5c0-46b3-8f86-a4cd910b7af3@gocontroll.com> On Fri, Dec 05, 2025 at 04:20:55PM +0100, Maud Spierings wrote: > Thanks for the review. > > On 12/4/25 17:17, Daniel Thompson wrote: > > On Mon, Dec 01, 2025 at 12:53:21PM +0100, Maud Spierings via B4 Relay wrote: > > > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC > > > with integrated boost controller. > > > > > > Signed-off-by: Maud Spierings > > > > > > +static int max25014_update_status(struct backlight_device *bl_dev) > > > +{ > > > + struct max25014 *maxim = bl_get_data(bl_dev); > > > + uint32_t reg; > > > + int ret; > > > + > > > + if (backlight_is_blank(maxim->bl)) > > > + bl_dev->props.brightness = 0; > > > > This isn't right. Why would you change the backlight level just because > > it is currently blanked (and sorry I missed this one last time). > > so just remove this bit then jeah? Yes. backlight_get_brightness() is all you should need. > > > + > > > + reg = TON_STEP * bl_dev->props.brightness; > > > > The correct way to honour blanking is just go call > > backlight_get_brightness() instead of reading the property directly. > > will do. Thanks. Daniel.