From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chintan Patel <chintanlike@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional
Date: Tue, 30 Dec 2025 13:37:03 +0200 [thread overview]
Message-ID: <aVO5X0NKSdkH6Ab5@smile.fi.intel.com> (raw)
In-Reply-To: <20251230052827.4676-4-chintanlike@gmail.com>
On Mon, Dec 29, 2025 at 09:28:21PM -0800, Chintan Patel wrote:
> omapfb provides several sysfs interfaces for framebuffer configuration
> and debugging, but these are not required for the core driver.
>
> Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support
> optional by using dev_of_fbinfo() to obtain the backing device at runtime.
> When FB_DEVICE is disabled, sysfs operations are skipped while the code
> still builds and is type-checked.
...
> + struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
Still the same issue I pointed out in v2 review.
> int t;
> +
> + if (!dev)
> + continue;
...
> + struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
> +
> + if (!dev)
> + continue;
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-30 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 5:28 [PATCH v3 0/4] fbdev: Make CONFIG_FB_DEVICE optional for drivers Chintan Patel
2025-12-30 5:28 ` [PATCH v3 1/4] fb: Add dev_of_fbinfo() helper for optional sysfs support Chintan Patel
2025-12-30 8:01 ` Helge Deller
2025-12-30 5:28 ` [PATCH v3 2/4] staging: fbtft: Make FB_DEVICE dependency optional Chintan Patel
2025-12-30 8:03 ` Helge Deller
2025-12-30 5:28 ` [PATCH v3 3/4] fbdev: omapfb: " Chintan Patel
2025-12-30 8:05 ` Helge Deller
2025-12-30 11:37 ` Andy Shevchenko [this message]
2025-12-30 18:01 ` Chintan Patel
2025-12-30 22:42 ` Andy Shevchenko
2025-12-30 5:28 ` [PATCH v3 4/4] fbdev: sh_mobile_lcdc: " Chintan Patel
2025-12-30 8:13 ` Helge Deller
2025-12-30 18:25 ` Chintan Patel
2025-12-30 11:35 ` Andy Shevchenko
2025-12-30 10:42 ` [PATCH v3 0/4] fbdev: Make CONFIG_FB_DEVICE optional for drivers Geert Uytterhoeven
2025-12-30 11:33 ` Andy Shevchenko
2025-12-30 17:59 ` Chintan Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVO5X0NKSdkH6Ab5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=chintanlike@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).