From: Dan Carpenter <dan.carpenter@linaro.org>
To: RachelOvrani <rachel.ovrani@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: Rename nDirection to new_direction
Date: Thu, 12 Feb 2026 13:13:43 +0300 [thread overview]
Message-ID: <aY2n12yxgH_wnMFM@stanley.mountain> (raw)
In-Reply-To: <20260212095715.2844-1-rachel.ovrani@gmail.com>
On Thu, Feb 12, 2026 at 11:57:15AM +0200, RachelOvrani wrote:
> Convert the variable 'nDirection' to 'new_direction'
> in drivers/staging/sm750fb/sm750_accel.c to comply
> with Linux kernel coding style guidelines.
>
> The variable holds a newly calculated direction value,
> so 'new_direction' makes the intent clearer than 'n_direction'.
>
> Checked with checkpatch.pl --strict: no warnings, no errors
Don't include this sort of thing in the patch description.
>
> Signed-off-by: RachelOvrani <rachel.ovrani@gmail.com>
> ---
This patch assumes we applied that previous patch but we won't.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2026-02-12 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 9:57 [PATCH v2] staging: sm750fb: Rename nDirection to new_direction RachelOvrani
2026-02-12 10:13 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY2n12yxgH_wnMFM@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rachel.ovrani@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox