Re: [PATCH v2 3/4] fbdev: au1100fb: Use %zu to printk a value of type size_t

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]

On Sat, Feb 07, 2026 at 08:06:18PM +0100, Helge Deller wrote:
> On 2/7/26 18:12, Uwe Kleine-König wrote:
> > %zu is the dedicated type for size_t. %d only works on 32bit
> > architectures where size_t is typedef'd to be unsigned int. (And then
> > the signedness doesn't fit, but `gcc -Wformat` doesn't stumble over this.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> >   drivers/video/fbdev/au1100fb.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> > index beba8befaec9..a0e1aceaf9a6 100644
> > --- a/drivers/video/fbdev/au1100fb.c
> > +++ b/drivers/video/fbdev/au1100fb.c
> > @@ -456,7 +456,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
> >   					    PAGE_ALIGN(fbdev->fb_len),
> >   					    &fbdev->fb_phys, GFP_KERNEL);
> >   	if (!fbdev->fb_mem) {
> > -		print_err("fail to allocate framebuffer (size: %dK))",
> > +		print_err("fail to allocate framebuffer (size: %zuK))",
> >   			  fbdev->fb_len / 1024);
> >   		return -ENOMEM;
> >   	}
> 
> I think there is a second hunk missing?
> 
> @@ -470,7 +470,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
>         fbdev->info.fix.smem_len = fbdev->fb_len;
> 
>         print_dbg("Framebuffer memory map at %p", fbdev->fb_mem);
> -       print_dbg("phys=0x%08x, size=%dK", fbdev->fb_phys, fbdev->fb_len / 1024);
> +       print_dbg("phys=0x%08x, size=%zuK", fbdev->fb_phys, fbdev->fb_len / 1024);

Ah, the compiler didn't stumble about this one because print_dbg is a
stub without DEBUG defined.

I will prepare a v3.

Best regards
Uwe


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]