Re: [PATCH v2 1/4] fbdev: au1100fb: Don't store device specific data in global variables

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hello Helge,

On Sat, Feb 07, 2026 at 08:04:21PM +0100, Helge Deller wrote:
> > @@ -547,7 +542,7 @@ void au1100fb_drv_remove(struct platform_device *dev)
> >   #ifdef CONFIG_PM
> >   static struct au1100fb_regs fbregs;
> 
> ^ you missed to delete "fbregs" now.
> Your previous series deleted it.

I guess this is a fallout from reordering the patches. Will fix.

> > -int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> > +static int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> >   {
> >   	struct au1100fb_device *fbdev = platform_get_drvdata(dev);
> > @@ -559,7 +554,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> >   	clk_disable(fbdev->lcdclk);
> > -	memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
> > +	memcpy(&fbdev->pm_regs, fbdev->regs, sizeof(struct au1100fb_regs));
> 
> Although memcpy() was used before, isn't this:
> 	fbdev->pm_regs = *fbdev->regs;
> sufficient and better?

Probably yes, that's a separate patch then.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]