From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Helge Deller <deller@gmx.de>
Cc: Chen Ni <nichen@iscas.ac.cn>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] fbdev: au1100fb: Don't store device specific data in global variables
Date: Sun, 8 Feb 2026 18:48:08 +0100 [thread overview]
Message-ID: <aYjLX1uGMkDugm39@monoceros> (raw)
In-Reply-To: <aYevgJ6cfe6JVlJq@monoceros>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Hello,
On Sat, Feb 07, 2026 at 10:34:21PM +0100, Uwe Kleine-König wrote:
> > > @@ -559,7 +554,7 @@ int au1100fb_drv_suspend(struct platform_device *dev, pm_message_t state)
> > > clk_disable(fbdev->lcdclk);
> > > - memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
> > > + memcpy(&fbdev->pm_regs, fbdev->regs, sizeof(struct au1100fb_regs));
> >
> > Although memcpy() was used before, isn't this:
> > fbdev->pm_regs = *fbdev->regs;
> > sufficient and better?
>
> Probably yes, that's a separate patch then.
Thinking again: this is copying from io memory. So both memcpy and
struct assignment might be a bad idea. I'll keep it as is, this driver
already occupies me much longer than I intended.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-02-08 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 17:12 [PATCH v2 0/4] fbdev: au1100fb: support COMPILE_TEST and fix multi-device support Uwe Kleine-König
2026-02-07 17:12 ` [PATCH v2 1/4] fbdev: au1100fb: Don't store device specific data in global variables Uwe Kleine-König
2026-02-07 19:04 ` Helge Deller
2026-02-07 21:34 ` Uwe Kleine-König
2026-02-08 17:48 ` Uwe Kleine-König [this message]
2026-02-07 17:12 ` [PATCH v2 2/4] fbdev: au1100fb: Mark several local functions as static Uwe Kleine-König
2026-02-07 17:12 ` [PATCH v2 3/4] fbdev: au1100fb: Use %zu to printk a value of type size_t Uwe Kleine-König
2026-02-07 19:06 ` Helge Deller
2026-02-07 21:32 ` Uwe Kleine-König
2026-02-07 17:12 ` [PATCH v2 4/4] fbdev: au1100fb: Make driver compilable on non-mips platforms Uwe Kleine-König
2026-02-07 22:02 ` kernel test robot
2026-02-07 23:04 ` kernel test robot
2026-02-08 11:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYjLX1uGMkDugm39@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox