public inbox for linux-fbdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Helge Deller <deller@gmx.de>
Cc: Chen Ni <nichen@iscas.ac.cn>,
	linux-fbdev@vger.kernel.org,  dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 3/6] fbdev: au1100fb: Use %zu to printk a value of type size_t
Date: Mon, 9 Feb 2026 08:33:59 +0100	[thread overview]
Message-ID: <aYmMyNMC0z8dLisS@monoceros> (raw)
In-Reply-To: <d6891ed3-0a6b-443d-b64f-10e8a17bde49@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hello Helge,

On Sun, Feb 08, 2026 at 08:24:43PM +0100, Helge Deller wrote:
> On 2/8/26 20:21, Helge Deller wrote:
> > On 2/8/26 18:58, Uwe Kleine-König wrote:
> > > @@ -465,7 +465,7 @@ static int au1100fb_drv_probe(struct platform_device *dev)
> > >       fbdev->info.fix.smem_len = fbdev->fb_len;
> > >       print_dbg("Framebuffer memory map at %p", fbdev->fb_mem);
> > > -    print_dbg("phys=0x%08x, size=%dK", fbdev->fb_phys, fbdev->fb_len / 1024);
> > > +    print_dbg("phys=0x%08x, size=%zuK", &fbdev->fb_phys, fbdev->fb_len / 1024);
> > 
> > The & seems to be wrong.
> 
> I see you fix it up in patch #4.
> Maybe simply merge them?

I see how my compile testing went wrong: I checked that

	make drivers/video/fbdev/

was happy on several archs (but not mips) but only starting with patch
#5 this actually compiled the driver. 🙄

I'll give it another go tomorrow or so.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-02-09  7:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08 17:57 [PATCH v3 0/6] fbdev: au1100fb: support COMPILE_TEST and fix multi-device support Uwe Kleine-König
2026-02-08 17:57 ` [PATCH v3 1/6] fbdev: au1100fb: Don't store device specific data in global variables Uwe Kleine-König
2026-02-08 17:57 ` [PATCH v3 2/6] fbdev: au1100fb: Mark several local functions as static Uwe Kleine-König
2026-02-08 17:58 ` [PATCH v3 3/6] fbdev: au1100fb: Use %zu to printk a value of type size_t Uwe Kleine-König
2026-02-08 19:21   ` Helge Deller
2026-02-08 19:24     ` Helge Deller
2026-02-09  7:33       ` Uwe Kleine-König [this message]
2026-02-08 17:58 ` [PATCH v3 4/6] fbdev: au1100fb: Use %pad to printk a value of type dma_addr_t Uwe Kleine-König
2026-02-08 17:58 ` [PATCH v3 5/6] fbdev: au1100fb: Make driver compilable on non-mips platforms Uwe Kleine-König
2026-02-09  6:30   ` kernel test robot
2026-02-09  7:27     ` Uwe Kleine-König
2026-02-09  9:16   ` kernel test robot
2026-02-08 17:58 ` [PATCH v3 6/6] fbdev: au1100fb: Replace custom printk wrappers by pr_* Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYmMyNMC0z8dLisS@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox