From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: tomasz.unger@yahoo.pl
Cc: andy@kernel.org, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fb_ra8875: replace udelay with usleep_range
Date: Thu, 19 Feb 2026 09:30:13 +0200 [thread overview]
Message-ID: <aZa8Baq8YW63q2W3@smile.fi.intel.com> (raw)
In-Reply-To: <20260218174737.86994-1-tomasz.unger@yahoo.pl>
On Wed, Feb 18, 2026 at 06:47:37PM +0100, tomasz.unger@yahoo.pl wrote:
> From: Tomasz Unger <tomasz.unger@yahoo.pl>
We do not accept changes without explanations.
Also where did you get this idea to convert udelay() to usleep_range()?
The API (in case it's okay to use) should be fsleep() nowadays.
(Note as well that we refer to the functions as 'func()' in the text.)
And last, but not least: have you checked carefully that this is even
possible change? This is quite a change in the behaviour and needs very
good justification and testing.
TL;DR: if any tool suggested this change to you, go and fix that tool
to stop spreading misleading ARs!
P.S.
NAK to all your three patches. Also check https://lore.kernel.org ML
archives on the similar changes in the past, they were all NAKed
(rejected).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-19 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260218174737.86994-1-tomasz.unger.ref@yahoo.pl>
2026-02-18 17:47 ` [PATCH] staging: fbtft: fb_ra8875: replace udelay with usleep_range tomasz.unger
2026-02-19 7:30 ` Andy Shevchenko [this message]
2025-10-20 19:15 Olle Lukowski
2025-10-21 7:37 ` Greg Kroah-Hartman
2025-10-21 8:12 ` Olle Lukowski
2025-10-21 8:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZa8Baq8YW63q2W3@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox