From: Daniel Thompson <danielt@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: daniel@riscstar.com, deller@gmx.de,
dri-devel@lists.freedesktop.org, jingoohan1@gmail.com,
lee@kernel.org, linusw@kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in sky81452_bl_parse_dt()
Date: Wed, 4 Mar 2026 10:32:45 +0000 [thread overview]
Message-ID: <aagKTbpLjTAymqiY@aspen.lan> (raw)
In-Reply-To: <20260203021625.578678-1-nichen@iscas.ac.cn>
On Tue, Feb 03, 2026 at 10:16:25AM +0800, Chen Ni wrote:
> The devm_gpiod_get_optional() function may return an ERR_PTR in case of
> genuine GPIO acquisition errors, not just NULL which indicates the
> legitimate absence of an optional GPIO.
>
> Add an IS_ERR() check after the call in sky81452_bl_parse_dt(). On
> error, return the error code to ensure proper failure handling rather
> than proceeding with invalid pointers.
>
> Fixes: e1915eec54a6 ("backlight: sky81452: Convert to GPIO descriptors")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Daniel.
next prev parent reply other threads:[~2026-03-04 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 7:54 [PATCH] backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in sky81452_bl_parse_dt() Chen Ni
2026-02-02 9:54 ` Daniel Thompson
2026-02-03 2:16 ` [PATCH v2] " Chen Ni
2026-03-04 10:32 ` Daniel Thompson [this message]
2026-03-06 13:31 ` Linus Walleij
2026-03-06 14:21 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aagKTbpLjTAymqiY@aspen.lan \
--to=danielt@kernel.org \
--cc=daniel@riscstar.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox