* [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg
@ 2026-03-12 11:18 Zile Xiong
2026-03-12 13:56 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Zile Xiong @ 2026-03-12 11:18 UTC (permalink / raw)
To: andy, gregkh
Cc: deller, abdun.nihaal, dan.carpenter, chintanlike, niejianglei2021,
dri-devel, linux-fbdev, linux-staging, linux-kernel, Zile Xiong
Replace the empty modifier argument with a simple identity macro.
This fixes the error reported by scripts/checkpatch.pl while keeping
the original semantics unchanged.
The generated code is equivalent and builds successfully.
Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 30e436ff19e4..380dd374a566 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -61,10 +61,10 @@ out: \
va_end(args); \
} \
EXPORT_SYMBOL(func);
-
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+#define fbtft_identity(x) (x)
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, fbtft_identity)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, fbtft_identity)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg
2026-03-12 11:18 [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg Zile Xiong
@ 2026-03-12 13:56 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-03-12 13:56 UTC (permalink / raw)
To: Zile Xiong
Cc: andy, gregkh, deller, abdun.nihaal, chintanlike, niejianglei2021,
dri-devel, linux-fbdev, linux-staging, linux-kernel
On Thu, Mar 12, 2026 at 07:18:07PM +0800, Zile Xiong wrote:
> Replace the empty modifier argument with a simple identity macro.
> This fixes the error reported by scripts/checkpatch.pl while keeping
> the original semantics unchanged.
>
> The generated code is equivalent and builds successfully.
>
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4..380dd374a566 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -61,10 +61,10 @@ out: \
> va_end(args); \
> } \
> EXPORT_SYMBOL(func);
> -
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +#define fbtft_identity(x) (x)
Someone sent this exact same patch before. Same name and everything.
https://lore.kernel.org/all/aYECoy7Apjwgzr9r@stanley.mountain/
A better sollution is to learn to just ignore checkpatch when it is
wrong. My previous email was longer.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-12 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 11:18 [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg Zile Xiong
2026-03-12 13:56 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox