From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, deller@gmx.de, airlied@linux.ie,
maarten.lankhorst@linux.intel.com
Cc: linux-fbdev@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O
Date: Fri, 29 Apr 2022 09:21:25 +0200 [thread overview]
Message-ID: <ac24d81e-f6c5-0763-909a-c15d223f1ea9@redhat.com> (raw)
In-Reply-To: <20220426120359.17437-5-tzimmermann@suse.de>
Hello Thomas,
On 4/26/22 14:03, Thomas Zimmermann wrote:
> Rename various instances of pagelist to pagereflist. The list now
> stores pageref structures, so the new name is more appropriate.
>
> In their write-back helpers, several fbdev drivers refer to the
> pageref list in struct fb_deferred_io instead of using the one
> supplied as argument to the function. Convert them over to the
> supplied one. It's the same instance, so no change of behavior
> occurs.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Suggested-by: Sam Ravnborg <sam@ravnborg.org>
I thougt the convention was to have Suggested-by before your S-o-B.
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-29 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:03 [PATCH v3 0/5] fbdev: Decouple deferred I/O from struct page Thomas Zimmermann
2022-04-26 12:03 ` [PATCH v3 1/5] fbdev: Put mmap for deferred I/O into drivers Thomas Zimmermann
2022-04-28 9:43 ` Dan Carpenter
2022-04-26 12:03 ` [PATCH v3 2/5] fbdev: Track deferred-I/O pages in pageref struct Thomas Zimmermann
2022-04-26 12:03 ` [PATCH v3 3/5] fbdev: Refactor implementation of page_mkwrite Thomas Zimmermann
2022-04-26 12:03 ` [PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O Thomas Zimmermann
2022-04-29 7:21 ` Javier Martinez Canillas [this message]
2022-04-29 7:27 ` Thomas Zimmermann
2022-04-29 7:38 ` Javier Martinez Canillas
2022-04-26 12:03 ` [PATCH v3 5/5] fbdev: Use pageref offset for deferred-I/O writeback Thomas Zimmermann
2022-04-29 7:34 ` Javier Martinez Canillas
2022-04-26 12:05 ` [PATCH v3 0/5] fbdev: Decouple deferred I/O from struct page Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac24d81e-f6c5-0763-909a-c15d223f1ea9@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).