From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48EC315AAC8 for ; Mon, 29 Jul 2024 15:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722268799; cv=none; b=XEE+CVXbNNFEdAtY6vpLj4XyWx8H87UKFeNUzWLp/S74UYZS6x3eTYOuwiR6i69iR/+TpHfzjexbiI+5YLRXqOR4EYKS3+aoxG3tyw8o8cZzfHBMXlXu1+YYDYn/MGsSyHHDkreHLwcjsy2vcCMjnXf3ddoPS9Orr5lhQXaGhqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722268799; c=relaxed/simple; bh=XlT0HYWbLqBz+dbZhicguoyqf4QgW3bMfFfjONXLltU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IIaWGl4/FOYKq6cPoaRjlU1oFf7cMV+K+NOXCodYtbTi9ke5lidZUmBH6FRvVhOm0Hm3Pfx6COfrweIYBfnV9IbAF7uyMQa42yp6nhCRqR5N8vnTe3v+mjWCHO6olbGbgmczDduehPynH4Hm67HDfnifW9L4/yuHNwzgbg5116M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R10ZU6Qs; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R10ZU6Qs" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-260f81f7fb5so2300546fac.0 for ; Mon, 29 Jul 2024 08:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722268797; x=1722873597; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rKORujp1kv0/6IBUNhxzZiJOGLH+iRzT6G5ZfGPNOlo=; b=R10ZU6QsU1W2k25ailzgETe2aB9RJRWszEagOPudi5+JFggktOZsqDQYy8BG23Qy6v sAyGLPP1yfCMZczfcBkmTUWffIszbGrBYZ7CTGDbAE/nD1nfsJ9NdPhfy4iPcX9VRHxK 8odEFC5QkduMqotHwFSR59O/CaIouLqcvYiWIYb43cGV9EK6XSCbBRog8Ir7KCaoEdQQ 2LMXi8w3y+0j5FRYE7kOf+Wzl8NnzWwioUXt64tBFAr/yutw4sM25cwgjOjJDckyHmNG /K6W3AvkvC+wXMZGtIEUdM7NJzvefuJCKkEJAIb4A7jX1LCJs8v0as5q/KyImABigjPo 0zdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722268797; x=1722873597; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rKORujp1kv0/6IBUNhxzZiJOGLH+iRzT6G5ZfGPNOlo=; b=T6ZsQn67+8A5ciNL7DKoCZUUs2rpknB88tXXtouq+YJHLEvqTp3myMSqR0Kknv6qDG XdCQ/9VB0kvRezGkVqv8n0sO3pcHfHkScriT92rPVVBAzaem2vzFVrRFvnzUJIVIxWaK 7614vq61t9V0iX9DUN+fYe96wYnpCwIkJOVosh5qrn3Udmo46o1TneeVwfy763104F4b 15tIYB+D9+cVMJYyx9Ktj6XtleQ9Kvh7SZFUTlgZeDrGqqJ8JFjgS2yOmdw3NgPMuj7x OLYtwLLCe1iTrTQ2WmmGG+Jp/IjYnjyDOfoexQ/7DhH9ge0sU3PI8Lqu1VaT3yMjcHfI 6SsA== X-Forwarded-Encrypted: i=1; AJvYcCV///epdzVIpe1DvB4HOVxrB83JWBj2h8H8qGzRT5TNGNkRbLS0UE2ha2uzB+Mt1CRYof2eNvcU0naMG1yfUSJnQdkCdN1PrICZOwU= X-Gm-Message-State: AOJu0YxyosfWbKow6KY0dZhWS/JHg4csIlxEz3NkaLaHcgPOuxd3wgWT qoUZSgq5ItdMI6/LaNI+ZhpwXuhXTLAZhsCp2eI8Q5nAYmhKYI27A0qWo4hydXg= X-Google-Smtp-Source: AGHT+IEIHagVgO9pv8gb/zQ7JpvS63INgCNeENDNmOULmSa/KXAfqwBHzEaMxKrukT2FJXfnEI3QZA== X-Received: by 2002:a05:6870:c152:b0:260:ffaf:8126 with SMTP id 586e51a60fabf-267d4cfd510mr10157250fac.9.1722268797401; Mon, 29 Jul 2024 08:59:57 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700::17c0]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-264fb59ec30sm1895997fac.0.2024.07.29.08.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 08:59:57 -0700 (PDT) Date: Mon, 29 Jul 2024 10:59:54 -0500 From: Dan Carpenter To: Helge Deller Cc: Christophe JAILLET , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe() Message-ID: References: <698958fb-4fc8-4288-b067-5843c651b093@gmx.de> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <698958fb-4fc8-4288-b067-5843c651b093@gmx.de> On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: > On 7/28/24 20:29, Christophe JAILLET wrote: > > If an error occurs after request_mem_region(), a corresponding > > release_mem_region() should be called, as already done in the remove > > function. > > True. > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > I think we can drop this "Fixes" tag, as it gives no real info. > If we're backporting patches then these tags really are useful. As I've been doing more and more backporting, I've come to believe this more firmly. I don't necessarily think this patch is worth backporting, but leaving the Fixes tag off doesn't mean it won't happen. People quite often leave the Fixes tags off of real fixes by mistake so AUTOSEL could still pick it up. You'd have to add: Cc: # reason goes here, and must be present > > Signed-off-by: Christophe JAILLET > > --- > > *Not* even compile tested only. > > Ok. > > > I don't know on what architecture it relies on. > > HP300 are old HP machines with an m68k CPU. > Not sure if someone still has such a machine :-) > It surprised me how many patches we backport for ancient stuff. But I guess the risk/reward equation still works because if the code isn't used there the risk is very small. regards, dan carpenter