Re: [PATCH] New Console system BK

Re: [PATCH] New Console system BK

[Skip Ford]

James Simmons wrote:
> 
> Since 2.5.1 I have placed into the kernel part of the new console system
> code into the DJ tree. So it has been well tested. I was hoping to have
> all the keyboard devices ported over to the input api and the fbdev
> drivers over to the new api. Unfortunely due to time restraints this will
> not be the case. So here goes the first installment of the new console
> system. Please test it yourselves and I will push it to Linus soon.
> 
>  http://www.transvirtual.com/~jsimmons/console.diff.gz

With your patch, I have to release the alt key between Fx keys to change
VTs.  Is that intentional?

Without the patch, I can hold down alt and hit F1, F2, F3, F4, then
release the alt key and I will have switched to each of the VTs.
With this patch, I have to press/release alt for each Fx key.

-- 
Skip


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] New Console system BK

[Dave Jones]

On Mon, Jul 01, 2002 at 08:11:28PM -0400, Skip Ford wrote:
 > James Simmons wrote:
 > > 
 > > Since 2.5.1 I have placed into the kernel part of the new console system
 > > code into the DJ tree. So it has been well tested. I was hoping to have
 > > all the keyboard devices ported over to the input api and the fbdev
 > > drivers over to the new api. Unfortunely due to time restraints this will
 > > not be the case. So here goes the first installment of the new console
 > > system. Please test it yourselves and I will push it to Linus soon.
 > > 
 > >  http://www.transvirtual.com/~jsimmons/console.diff.gz
 > 
 > With your patch, I have to release the alt key between Fx keys to change
 > VTs.  Is that intentional?
 > 
 > Without the patch, I can hold down alt and hit F1, F2, F3, F4, then
 > release the alt key and I will have switched to each of the VTs.
 > With this patch, I have to press/release alt for each Fx key.

Strange, that's a reoccurance of a bug that happened many moons ago
circa 2.5.4-dj or so, which James then subsequently fixed. Seems he
dropped a bugfix or two..

        Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
No, I will not fix your computer.
http://thinkgeek.com/sf

Re: [PATCH] New Console system BK

[James Simmons]

>  > Without the patch, I can hold down alt and hit F1, F2, F3, F4, then
>  > release the alt key and I will have switched to each of the VTs.
>  > With this patch, I have to press/release alt for each Fx key.
>
> Strange, that's a reoccurance of a bug that happened many moons ago
> circa 2.5.4-dj or so, which James then subsequently fixed. Seems he
> dropped a bugfix or two..

Ah. I was using the old patches. I will have to find the fix and put it
into the keyboard driver.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
No, I will not fix your computer.
http://thinkgeek.com/sf

[PATCH] New Console system BK

[James Simmons]

Since 2.5.1 I have placed into the kernel part of the new console system
code into the DJ tree. So it has been well tested. I was hoping to have
all the keyboard devices ported over to the input api and the fbdev
drivers over to the new api. Unfortunely due to time restraints this will
not be the case. So here goes the first installment of the new console
system. Please test it yourselves and I will push it to Linus soon.

The goal is to create a system we can use keyboards without the console
system and the same true for framebuffer devices. This is most helpful on
embedded devices. The other goals to make the VT console system more
modular and lighter weight. The other goal is to make the VT tty system
multi-desktop.

Here are the changes so far:

I) Removal of struct kbd_struct from the sysrq handler. Why drag itr along
   when only two sysrq functions actually use it.

II) Massive rewrite and cleanup of keybaord.c.

III) Place struct tty_struct into struct vc_data. This sets up a one to
     one relationship. Avoids the nasty tricks of playing with fields from
     console_driver.

IV) Cleanup of VT tty/console initialization. A vty_init function to make
    it cleaner.

diffstat:

 arch/i386/kernel/apm.c         |    2
 arch/ppc/xmon/start.c          |    2
 arch/ppc64/xmon/start.c        |    2
 drivers/acpi/system.c          |    2
 drivers/char/console.c         |   82 ++--
 drivers/char/keyboard.c        |  779 +++++++++++++++++++++--------------------
 drivers/char/sysrq.c           |   46 +-
 drivers/char/tty_io.c          |   15
 include/linux/console_struct.h |    1
 include/linux/sysrq.h          |   13
 11 files changed, 485 insertions(+), 459 deletions(-)


The BK patch is at:

 http://linuxconsole.bkbits.net/dev

diff:

 http://www.transvirtual.com/~jsimmons/console.diff.gz

   . ---
   |o_o |
   |:_/ |   Give Micro$oft the Bird!!!!
  //   \ \  Use Linux!!!!
 (|     | )
 /'\_   _/`\
 \___)=(___/




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf