From: Michail Tatas <michail.tatas@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: sm750fb: Change camelCase to snake_case
Date: Mon, 25 May 2026 02:13:08 +0300 [thread overview]
Message-ID: <ahOGBLV2g5HUZrr6@michalis-linux> (raw)
In-Reply-To: <ag_ucCZEOnZuJOCz@stanley.mountain>
On Fri, May 22, 2026 at 08:49:36AM +0300, Dan Carpenter wrote:
> On Fri, May 22, 2026 at 02:39:01AM +0300, Michail Tatas wrote:
> > Change variable names from camelCase to snake_case
> > as per the Linux Kernel standards.
> >
> > These changes remove 9 CHECK messages from checkpatch.pl
> > regarding sm750.c, sm750.h and sm750_hw.c
> >
> > Tested changes by building the module sm750fb/
>
> Don't put this kind of meta comment in the commit message. Put it
> under the --- cur off line.
>
> Please wait a day between resends.
>
> I don't think you're working against the correct staging-next
> tree.
>
> regards,
> dan carpenter
>
Thanks a lot for the quick replies, much appreciated!
Dan you are correct thanks for noticing, I was
working on the main branch.
Some variables have not yet been converted, so
I will send them on a separate patch series as a v2
prev parent reply other threads:[~2026-05-24 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 23:39 [PATCH] Staging: sm750fb: Change camelCase to snake_case Michail Tatas
2026-05-22 4:43 ` Greg KH
2026-05-22 5:49 ` Dan Carpenter
2026-05-24 23:13 ` Michail Tatas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahOGBLV2g5HUZrr6@michalis-linux \
--to=michail.tatas@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox