From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 427CC3FF1D9 for ; Wed, 3 Jun 2026 07:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780472068; cv=none; b=UVqLGOyAzdn3eqWTrkgqB8Baj1l97ORnvwgzW/IBBpQBv5R++b1aU6qhEKnfgbnCQ+/V3JsHUxD1pFyQSG+TWIX/m6ZXwC3QnKu1aatEvzoKvqZUyXeUVeIAHjO5kWvt6WwYPO7/GhJ1XRQEvRxoINfzm4lxvl7NKUnFyG3O4Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780472068; c=relaxed/simple; bh=08RidtlahiJ8c10vz6uXOCC0lnAJVvKCOPsHPm83Rbw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dO2vcK04qH1QH6NecAF3QjW7sjejJucFBJkn7vsewrKKy8MN+Nx4HWEkWl0pNAzSbI6+LLHrpIacAc7Rz+d32kgmwX4aK9J13DIo3B4eMj5W12t00Cuuc5Isht/C29u63jik4aUDzUXnu/vQuUIynknnt6M151oft6hs9bD/mPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i/2TzDlJ; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i/2TzDlJ" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-68d23396ed3so6556366a12.1 for ; Wed, 03 Jun 2026 00:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780472065; x=1781076865; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tPiXO1dCCP98YnBjWC02+T/M/Rv7LEFPOyMbOWtK8IE=; b=i/2TzDlJw3YyMuL06BYvYuUywWByQ/Sm6zwf9L4uSYtdHI+IWCxZ3wHtyL46XIBrT6 zc11fqi61VKGe8SePKulQvOZnaB7tkc4AXmvkK3/3gjcYQJZpTgNOLSMY/TACeGUPw0e sOsSLP83PYFxFb2pNIKFKh0xl/ck+fztQQrrSN7h8r11ptCMnaOTP4Uh2rnDGLRCQbxu uQmTkjUDGDGGk0byTRoK3HOgxWKduSr7O0boFf4mFrDFYzram8neQk3WabQy53AsgsW6 kJOMW4fOE379qCaFCM2mba6gSciAYGYBcqjU4LogULbE+N//EvV9XX2YV/4LntTxF12M xpjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780472065; x=1781076865; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tPiXO1dCCP98YnBjWC02+T/M/Rv7LEFPOyMbOWtK8IE=; b=qdiYh9CU3nBZNNrfUpZoSh1P1qei0yDcp9cSZOJsPwm0Ho8iBq1dipX8ySdDA2ffcX YvWPAGcfGCKYKsxb/zV+bYYaj9QMZR1vtZe+Kl9u5wx+WCfp+7d/KoDHXK9O6FoPWuj8 dl6UDY/Wmr1fMSEBTO6IhtFwPnjWC+4u25i4t+a5aw0MRFAaP7PX3KQXDCVz4MX+Jhv/ 4wkXQJ+GJZIxnTCMnZ6fSqOJUt9OkAfwHU4B2+ogKTG8b+Zllf6QS3iO4iV+nWZjRmf5 NGq4aBQ31bSabDSSO5tOFrUy+cNc6wxDp+9csFFTy9NEp0uG+6Oa7dVV0i2ofPmxCetK 2CHg== X-Forwarded-Encrypted: i=1; AFNElJ+cvQ3JoSV9zJiM/JPlXZoak91SRu7mAG83iIe/eZlVEo76hS4y5wQ7O8wyafkmJlzmsNq1Jyx4XD9uRw==@vger.kernel.org X-Gm-Message-State: AOJu0YzG0lb1/vEoji9Ihg2qUdaE2EiN2Ov/teUYyOhrw6hgEh69qAJj Nol1FgdOTw7w458fW1hz7NRBsu9h0/0YqW2D005CDRgEY81nVH0/68/w X-Gm-Gg: Acq92OEB6V0E2LQLPDEfFgDOip/HE6fUCp/lHG8dYrdcgcHQc2d/52UoCWj48dM11D2 x0hjgD4RMt0pe8xNkOG2b0Zrnm7/JpxXSM8rOqp6uE05cnM1ai4WA7nuOXrYEXdQp0GHQqZpX5M 1PaTxjjZXWBGpE/9lIr3M2p6IuU4pp5BqR716EXJJKbB5rrZHKyFRD2a9xT9chl6H6gqnsRpk3H xvR5e23oS05Bns23xXXsmnPvXKsb30LvasMkUCBhZ4mta+QFPdWtyMKeHnqBVHQRA7c1KXRHNhy BpoZzbZrvxnB7M7UI7l0/z8JksPYOni0TsiTRbhotKWOw25UISQyRstagQFdMSQuZNF8MKrGZY/ BEkhBA6fQUMkD/0JjI0LFgFaiB2XcmaS6m69Pn5A7UgHOztKRDZV+tSKnaBLQXyglgWlxKQgKyG zwve68DxNJqVNX/BgrzRVNha2EtMr+hQ== X-Received: by 2002:a17:906:f58d:b0:bec:64d4:3869 with SMTP id a640c23a62f3a-bf0b0fdda85mr96495066b.4.1780472064614; Wed, 03 Jun 2026 00:34:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0517721e5sm102019166b.9.2026.06.03.00.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 00:34:24 -0700 (PDT) Date: Wed, 3 Jun 2026 10:34:21 +0300 From: Dan Carpenter To: Thomas Petazzoni Cc: Andy Shevchenko , Greg Kroah-Hartman , Helge Deller , Thomas Zimmermann , Chintan Patel , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] staging: fbtft: Use sysfs_emit_at() to print to sysfs file Message-ID: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding This scnprintf() uses the wrong limit. It should be "PAGE_SIZE - len" instead of just PAGE_SIZE. We're not going to hit the limit in real life since we are printing at most FBTFT_GAMMA_MAX_VALUES_TOTAL (128) u32 values, however, it's still worth fixing. Use sysfs_emit_at() to fix this since this is a sysfs file. Fixes: c296d5f9957c ("staging: fbtft: core support") Signed-off-by: Dan Carpenter --- drivers/staging/fbtft/fbtft-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index d05599d80011..343545e83a37 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -98,7 +98,7 @@ sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf) mutex_lock(&par->gamma.lock); for (i = 0; i < par->gamma.num_curves; i++) { for (j = 0; j < par->gamma.num_values; j++) - len += scnprintf(&buf[len], PAGE_SIZE, + len += sysfs_emit_at(buf, len, "%04x ", curves[i * par->gamma.num_values + j]); buf[len - 1] = '\n'; } -- 2.53.0