From: Dan Carpenter <error27@gmail.com>
To: Onish Sharma <neharora23587@gmail.com>
Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: rename pvReg to pv_reg
Date: Thu, 28 May 2026 17:15:26 +0300 [thread overview]
Message-ID: <ahhN_kiSb-yRWfiI@stanley.mountain> (raw)
In-Reply-To: <20260528133627.10850-1-neharora23587@gmail.com>
On Thu, May 28, 2026 at 07:06:26PM +0530, Onish Sharma wrote:
> Rename pvReg to pv_reg to comply with kernel coding style (checkpatch.pl)
> and improve readability.
>
> Signed-off-by: Onish Sharma <neharora23587@gmail.com>
pv stands for pointer void. It's Hungarian notation and it's not
allowed.
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-28 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 13:36 [PATCH 1/2] staging: sm750fb: rename pvReg to pv_reg Onish Sharma
2026-05-28 13:36 ` [PATCH 2/2] staging: sm750fb: rename setAllEngOff Onish Sharma
2026-05-28 14:14 ` Dan Carpenter
2026-05-28 14:15 ` Dan Carpenter [this message]
2026-05-29 9:52 ` [PATCH v2] staging: sm750fb: rename pv_reg to io_base Onish Sharma
2026-05-29 10:41 ` Dan Carpenter
[not found] ` <CAOWJOpvJnSeS=1sO2mujC9tNi9_cQGgJ6S0j6xvkAp8KRnudjg@mail.gmail.com>
2026-05-29 11:28 ` neha arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhN_kiSb-yRWfiI@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=neharora23587@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox