From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A52ED3B102F; Tue, 9 Jun 2026 19:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781031998; cv=none; b=KEqkm9w3Rhc+WAmIzTbr89x7hk36BzgDY33A49zDvLdDaIPg+ABogsnmGoJsGxso4Bp1l9PRhKymL0MZ+jkEBGJc5W72WWaK3EUC/P8aAsnR7ObhGsJH3tM96ONoERaM6rmvb4bzHhrJt2xD/SySUnrWLBoPDrX/2as0M8LWyxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781031998; c=relaxed/simple; bh=ZzI9gm2rnwVsOuZIILAhH/PEbhSZzbC826SvMBF3MYc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OjoRUWYUNUPtm5umPvyrJbX4RZ1gDHoeUsNPaW4HIaJkEVnmkXNtDy8GI/NWudGTvdXWqv/rOEZfNvVGuFSS1A/uWeLdzgQxEEvnKC1sbKAvuBzzxqkyo3REnArboO3K5a+jGKpQTCA+JttlU7DCYsb22t3L4zFb6fGS7bhcY/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Wxc6FhHu; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Wxc6FhHu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781031997; x=1812567997; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZzI9gm2rnwVsOuZIILAhH/PEbhSZzbC826SvMBF3MYc=; b=Wxc6FhHuLfy7cJ6zcidp+Ta6T84pV3YEUD1QRvrNaPWse0QYgyk4M5Ey +oAHN2hlYM7PFkunA2mNu8cOtqdaaNCtI4rdvanL+Bmv6loExfjdMMfra XjuB1NWRng+5T43/z1vvRsNJu1v67imPXgwbh95cicQkhGBguULzs8wIw tgWlxwysBAmFNya51etBHfjYbyLiKAuWi+URKi4XXsjWr76LHoruTGZpg ciaRpSfwDGS+0o9EH6kiMIpddzOxpp2NMDZGJ4S7M1by4x/3gpVgyWXDx tVuJQiRALjrx2QAwVYislARNyuPxjDVfuoLxlG0x63ZnDgwik+KPj+8LF Q==; X-CSE-ConnectionGUID: hNs3aruVQwSWjYbETibo3Q== X-CSE-MsgGUID: sKyIQdoORWaZiImAonHyBQ== X-IronPort-AV: E=McAfee;i="6800,10657,11812"; a="85655596" X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208";a="85655596" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 12:06:36 -0700 X-CSE-ConnectionGUID: 2hlOv1h7SOiWJTRk+l/wxg== X-CSE-MsgGUID: LuhpETyxQC60gUwspMHaVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208";a="241806001" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.162]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 12:06:31 -0700 Date: Tue, 9 Jun 2026 22:06:29 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 04/14] mfd: lm3533: Pass only regmap and light sensor presence to child devices Message-ID: References: <20260606045738.21050-1-clamor95@gmail.com> <20260606045738.21050-5-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260606045738.21050-5-clamor95@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Jun 06, 2026 at 07:57:28AM +0300, Svyatoslav Ryhel wrote: > Instead of passing the entire lm3533 core data structure, only pass the > regmap and the light sensor presence flag to child devices. ... > struct lm3533_als { > - struct lm3533 *lm3533; > + struct regmap *regmap; > struct platform_device *pdev; And this pdev is probably not needed. But I haven't checked the whole lot of the patches yet. > unsigned long flags; ... > struct lm3533_ctrlbank { > - struct lm3533 *lm3533; > + struct regmap *regmap; > struct device *dev; Ditto. > int id; > }; -- With Best Regards, Andy Shevchenko