From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6BB823D2A4; Tue, 9 Jun 2026 19:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032214; cv=none; b=VQ35IosD1DX7aWUBBNjuiRZRXTXE1tAKKvIT9Q6Xawf1uPgESGy6xrhTvqdxbyLKEySrMb5PFnnpYcErpgB6OyV56MtYRwL1yZEsaRBjWbHsL3aHGUmliX7YgFWpsnCtlVNKnLgWrQ2/tCf+lz04QjVzh3WULAMWJLRk7HqAEpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032214; c=relaxed/simple; bh=WS6JfaEA3BwmbJKvOhjIvyQekZrai9npTeo54lk95W0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jBOKzb1q7uUYV0rez24a/yApri9UR7MC5z6Mpat5zrYXRo9OMNvHrk5h3/TnPyOYkMvqpJhjIecJQXvTbjspQIK0alG/JWIF20vkg3vzN2DDz1dXHJ870pxekUjyNqfsTS2+RVm1MG87Jc9uReZDBhWhYojN2xQO5ITKuuTHOys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FtoAE7Bi; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FtoAE7Bi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781032212; x=1812568212; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WS6JfaEA3BwmbJKvOhjIvyQekZrai9npTeo54lk95W0=; b=FtoAE7BiPJ6knMitI9bTu7lKOsLqd5Xt/uu/aI2Er+VgNZkQu68B77ks PuB5FJqGhFRXsD7cjzjKsdd70NLWvUTctQZbpt6OE4bN43Og936XDlKQC Cru0rD85vlfadwEQt+ppdFVfyhIH1UPoS3xXspuGBWx5mkw5QGa7cJWTt p2xGdbOVTl4FVTK8jh0X8eTB6Z448SLY1OLvFIwXOkpGk+qNJ/6SDJFW1 4vXvr6IEvbx4XL8Lj64ip30onSeBz3fIUVLw2TwT4k0nT6yBjrTjMEn5N dwNwgP4SsaARfaNhFVchjfAU6lW+HTrpCI1dr+NH96h2elVSnHIpDLTSV g==; X-CSE-ConnectionGUID: iI0HNBiIRrC6jqevkRuRcQ== X-CSE-MsgGUID: iLoPAbT3TRKK4mpYv/4RRg== X-IronPort-AV: E=McAfee;i="6800,10657,11812"; a="92374865" X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208";a="92374865" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 12:10:12 -0700 X-CSE-ConnectionGUID: mIKaIEDCTdGpbdmVntiHWA== X-CSE-MsgGUID: N/5hmFWRSF2cAslIVueonw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,196,1774335600"; d="scan'208";a="269960410" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.162]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2026 12:10:07 -0700 Date: Tue, 9 Jun 2026 22:10:04 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 05/14] iio: light: lm3533-als: Remove redundant pdata helpers Message-ID: References: <20260606045738.21050-1-clamor95@gmail.com> <20260606045738.21050-6-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260606045738.21050-6-clamor95@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Jun 06, 2026 at 07:57:29AM +0300, Svyatoslav Ryhel wrote: > The lm3533_als_set_input_mode and lm3533_als_set_resistor functions are > used only in lm3533_als_setup. Incorporate their code into > lm3533_als_setup directly to simplify driver readability. Use func() when referring to a function in the commit message. ... > static int lm3533_als_setup(struct lm3533_als *als, > const struct lm3533_als_platform_data *pdata) > { > + struct device *dev = &als->pdev->dev; > int ret; > > - ret = lm3533_als_set_input_mode(als, pdata->pwm_mode); > + ret = regmap_assign_bits(als->regmap, LM3533_REG_ALS_CONF, > + LM3533_ALS_INPUT_MODE_MASK, pdata->pwm_mode); > if (ret) > - return ret; > + return dev_err_probe(dev, ret, "failed to set input mode %d\n", > + pdata->pwm_mode); > > /* ALS input is always high impedance in PWM-mode. */ > if (!pdata->pwm_mode) { > - ret = lm3533_als_set_resistor(als, pdata->r_select); > + if (pdata->r_select < LM3533_ALS_RESISTOR_MIN || > + pdata->r_select > LM3533_ALS_RESISTOR_MAX) > + return dev_err_probe(dev, -EINVAL, > + "invalid resistor value\n"); > + > + ret = regmap_write(als->regmap, LM3533_REG_ALS_RESISTOR_SELECT, > + pdata->r_select); > if (ret) > - return ret; > + return dev_err_probe(dev, ret, "failed to set resistor\n"); > } > > return 0; Wondering if it would be better to /* Bail out when in PWM-mode */ if (pdata->pwm_mode) return 0; /* ALS input is always high impedance in PWM-mode. */ ... as the above changes almost every line in that conditional. -- With Best Regards, Andy Shevchenko