From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE363002D1; Wed, 10 Jun 2026 18:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781117671; cv=none; b=FRmRCfTiL4bvJ7PG5BeoMcaElgN79KpnfDx7f5dt09nUTTaukKTOC1RvA8EJBa8AT7c2EERDEZ5lubU2eAdaS9nwjYBbnHVeRGq9hB9kBtsldYo/SEJEz2itsf40486V4BtGfWa8cxEFJOj4h+9GNnzwq6xoG/pmYbS97xVI10k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781117671; c=relaxed/simple; bh=n2hV3B6fSubnHZBMr0PxV8zbuDwCIP6mPGSYy7ANljI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RXdNtaG0HIbqID6Us+Ug9SgwBf556cvoHmHPxMgn4/ttVdlDVejLl8NDBJAp227fGjSrK5dPAjhC4mSjFRh0L3jgsKldb19p6g1aCXZmNfiKx3doZ8YoOfBaLpqdd7XR3z91NLMMmJa8JhO3lGG7fHGH1xnd8ywKxSectWKbCEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N8XJTKA0; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N8XJTKA0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781117669; x=1812653669; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=n2hV3B6fSubnHZBMr0PxV8zbuDwCIP6mPGSYy7ANljI=; b=N8XJTKA0GatgLugjB8xAOpEJ27IY8Pmn3gstdZWB5v0m2eCcLIv63Hnd UoetNvREVtCQewES7n1lIG83PuwiPDYddZlFPaAosJbPTZpP5krhGo2MH EcYE4HwIPqvdDmZHn6I+9i3K++QIHYQCPO77PSmS10/DMh3lUlGTRlJSn GvDNYcP/tV6kBUnWe4krzAWqMVpUdEwICJxBxvQKOuWXRMLzPASvQO9r5 mn3RedqFaHDgejkspORMGhGx08adhLuJRjEEuBAZVkVncXeLhdBJJF5so aFgI1vKhAfW+e8QhbbDS3pRPO2xfsboEleaVTXRBlhrgaXL0Jk8IP7baZ g==; X-CSE-ConnectionGUID: q2X1zFivRf2YtSvVjlVk9Q== X-CSE-MsgGUID: 2zD0akIfS0WSbkhQFkCSNw== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="81054262" X-IronPort-AV: E=Sophos;i="6.24,197,1774335600"; d="scan'208";a="81054262" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 11:54:28 -0700 X-CSE-ConnectionGUID: bQUxm7piTyaMuGNbETdheg== X-CSE-MsgGUID: 17pHQK9bRmy31JSdm4IojA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,197,1774335600"; d="scan'208";a="250530135" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.38]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 11:54:22 -0700 Date: Wed, 10 Jun 2026 21:54:20 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 14/14] video: leds: backlight: lm3533: Support getting LED sources from DT Message-ID: References: <20260606045738.21050-1-clamor95@gmail.com> <20260606045738.21050-15-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jun 10, 2026 at 05:45:28PM +0300, Svyatoslav Ryhel wrote: > вт, 9 черв. 2026 р. о 22:23 Andy Shevchenko пише: > > On Sat, Jun 06, 2026 at 07:57:38AM +0300, Svyatoslav Ryhel wrote: > > > Add Control Bank to HVLED/LVLED muxing support based on the led-sources > > > defined in the device tree. ... > > > + int ret, i; > > > > No need to add 'i'. > > This is personal preference as well. There is no strict rule that > iteration variable must be defined strictly in the for loop. This is a preference by Linus who is the leader of the project. Also in IIO we have some set of maintainer preferences. > > > + for (i = 0; i < led->num_leds; i++) { > > > > for (unsigned int i = 0; i < led->num_leds; i++) { > > > > > + if (led->leds[i] >= LM3533_LVCTRLBANK_MAX) > > > + continue; > > > + > > > + output_cfg_shift = led->leds[i] * 2; > > > + output_cfg_val |= led->id << output_cfg_shift; > > > + output_cfg_mask |= OUTPUT_LVLED_MASK << output_cfg_shift; > > > + } -- With Best Regards, Andy Shevchenko