From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683EB25393E; Tue, 23 Jun 2026 09:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205394; cv=none; b=SM0rcvFeBVn4zraQbC0GA9xd8nPF8vLEicW5Jm6hjYhYKrJELzXF5ZHiDDnRqNtgQ5prbUrCsBi95LzbHkSC3mM80Y9LUCPE6cz+qdItfKG/Tk9aH2/w9l0f6r0iI1vV7cwmpVd7wnCv3dy0BN01S3QAc65r/6/fQN5do/mldzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205394; c=relaxed/simple; bh=PPCpMq7lYRc/Iu6FOHaKbGMIYgwijB1RSueN/w0Qn5M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W8LOAp/+KBkOam58ETJG4Rj0+ZNES6NPM7MuTQ4eI+7H8a2w9gYa46rC3CR0dz7C8bK4x4I+VVQXaVGofMDEjTQWij3v6F0D4qNWKDCdDNIFWCsKyiUcYCixacbGq++TXgLKpz2g8/gjOamuaRutXDYPWzWc56kyDpgjrBFZjVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YZTPqk47; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YZTPqk47" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782205394; x=1813741394; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PPCpMq7lYRc/Iu6FOHaKbGMIYgwijB1RSueN/w0Qn5M=; b=YZTPqk47brywJZQzIPjKthF0j58+ifHQAdNgNGI79qIH/Ff9g5TEsuyJ ORiyhMOzsFAQd6H/Mkd6nEtrnfs7V8p0AWkmeQXU3Xn5qTd7ROR6CHL9q Y8DADY2fwD4bmk9gD+U6t8J6FFP+mAy/9q3J9413uPz6N9yyYw5PNUKlq jbrEjo/GSbkEBH1ga0Tt79OncL0GBwoZA2/aE6zv+OoxJqpiOAUdMmdSH oyvVK4rGlOpqKhXRFC780XXaz28go/IqGeRIo04dnZ7NEspPNPxNaVQ8F LNSBaACw2SpvMg3uOfwv7fk54mcgBZ4K+iFAuCRIBxQSKW5ak9fdI4DrR g==; X-CSE-ConnectionGUID: HPCO5SdCQtimfd6GE0cBMw== X-CSE-MsgGUID: 7KDfMFnjSJ6cc4appWa+aA== X-IronPort-AV: E=McAfee;i="6800,10657,11825"; a="93307765" X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="93307765" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 02:03:13 -0700 X-CSE-ConnectionGUID: NBgyK0lZRCGMzmoTmLttMQ== X-CSE-MsgGUID: +5fEtc7WSbOdM/6RvOjruw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="287598339" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.7]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 02:03:08 -0700 Date: Tue, 23 Jun 2026 12:03:06 +0300 From: Andy Shevchenko To: Amit Barzilai Cc: javierm@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org, gregkh@linuxfoundation.org, deller@gmx.de, azuddinadam@gmail.com, chintanlike@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 2/4] drm/ssd130x: Add RGB565 support to SSD133X family Message-ID: References: <20260622152506.78627-1-amit.barzilai22@gmail.com> <20260622152506.78627-3-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622152506.78627-3-amit.barzilai22@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 22, 2026 at 06:25:04PM +0300, Amit Barzilai wrote: > SSD133X screens were getting 8bpp (RGB332) instead of the 16bpp > (RGB565) that they support. This change adds a boolean to the > deviceinfo struct selecting whether the variant is driven at > DRM_FORMAT_RGB565. > > Changed SSD133X to now utilize 65k color (RGB565). ... > - * Each Segment has a 8-bit pixel and each Common output has a > - * row of pixels. When using the (default) horizontal address > - * increment mode, each byte of data sent to the controller has > - * a Segment (e.g: SEG0). > + * Each Segment holds one pixel and each Common output has a row > + * of pixels. A pixel is 8 bits (one byte) in the 256 color > + * (RGB332) format or 16 bits (two bytes) in the 65k color > + * (RGB565) format. When using the (default) horizontal address > + * increment mode, the pixel data is sent Segment by Segment > + * (e.g: SEG0 first). > * > * When using the 256 color depth format, each pixel contains 3 > * sub-pixels for color A, B and C. These have 3 bit, 3 bit and > * 2 bits respectively. Something wrong with the plural. There is a difference between "3-bit" and "3 bits", but "3 bit" is odd. > + * > + * When using the 65k color depth format, each pixel contains 3 > + * sub-pixels for color A, B and C. These have 5 bit, 6 bit and > + * 5 bits respectively. Same mistake is repeated here. ... > + /* > + * Per-variant output format selector for the SSD133X data path. The > + * hardware can drive the panel in RGB332 (1 byte/pixel) or RGB565 > + * (2 bytes/pixel); this is a policy choice per variant, not a In other comments it was spelled fully, be consistent "1 byte per pixel", "2 bytes per pixel". > + * capability probe. When set, the variant is driven at RGB565. > + */ -- With Best Regards, Andy Shevchenko