From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5708C3BE659; Thu, 25 Jun 2026 07:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372416; cv=none; b=toN7TW88zGffffOXEt2LAl6jWSdaD6SZULHbmFGhQllCfgWa+8EvZ14YGj4j55/J2k9L8Q1s0VV3kD1LJPT4Q2biv4FKqfNUiZMoZPKxkAuDfYzKqHirYXKBoTBQV1uaVm7loYLBjHL7Gt2+134nNwUVsh8CFrQE1jN4Xd6ejcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372416; c=relaxed/simple; bh=/JAMbYV6/MvMS5YmktMrYNIX493b56t4m6w329yYRCY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WLm6yPJoIJPRgVjd2XORBieLRHwy4IA7kDQJpBc7P4vkyUfS5+SuweZRtFKT3o1TG4T29lxuyLj8vqs8IR1R9XFcQDexSFCtvhsOMasop27BSbjRSLf/1uXyG2Hlwa4hSCaWMW31hyDhCLVMmm9osxj5EehXXkowozGuQey/BcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ETSqUzsh; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ETSqUzsh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782372414; x=1813908414; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/JAMbYV6/MvMS5YmktMrYNIX493b56t4m6w329yYRCY=; b=ETSqUzshfU7gxWrTA/fMB0Mb9/V2FTIm617Z1QHjw1jl619AfRwhsR7I yiX1eWs8KH/4tczmlVKt9QKvxq5PKFPC7Q+ju6ZYn40NGBEG3JaALq7Zo uDxfJ7MWmsuZNW/oNidMtUajDn37ZNy0iyFiXJNYq/iku+6l+1IzEkDW/ 6dwyFO13BHrj8W8q33NSJ0yUm1QIuPbr91K56v5wzT5z1TMcowYlJ++x+ 6MPAd6CJx5Yx/U2cv3j2hAeINd2SBHjnovgESZ8i/fOY16ZQ93qf6yOff wnWaav8OOfkAK1yW81QVor8lHdc5fTBvACcNry2qmw5OKSn8EjnwBK0lb w==; X-CSE-ConnectionGUID: oRmHxVOgTbqe2Zg89uRUMQ== X-CSE-MsgGUID: wH3+cA4sThSDi0FjSX2vNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11827"; a="94636021" X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="94636021" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 00:26:54 -0700 X-CSE-ConnectionGUID: 0cBg5HpcQ92wuLGB//QaJw== X-CSE-MsgGUID: 7G2IFw+sSgmoVJWfCXXYsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="249049141" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.93]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 00:26:49 -0700 Date: Thu, 25 Jun 2026 10:26:47 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v5 07/14] mfd: lm3533: Use dev_groups in struct device_driver Message-ID: References: <20260617080031.99156-1-clamor95@gmail.com> <20260617080031.99156-8-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Jun 25, 2026 at 10:24:00AM +0300, Andy Shevchenko wrote: > On Wed, Jun 17, 2026 at 11:00:24AM +0300, Svyatoslav Ryhel wrote: ... > > .attrs = lm3533_attributes > > }; > > > > +static const struct attribute_group *lm3533_attribute_groups[] = { > > + &lm3533_attribute_group, > > + NULL, > > +}; > > We have ATTRIBUTE_GROUPS() macro. Okay, it uses is_visible, so __ATTRIBUTE_GROUPS() that we can still use. ... > > +++ b/drivers/video/backlight/lm3533_bl.c > > Same as per above. -- With Best Regards, Andy Shevchenko