From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Walmsley Date: Wed, 31 Oct 2012 05:49:44 +0000 Subject: RE: [PATCH] omap2-clk: Add missing lcdc clock definition Message-Id: List-Id: References: <1351698962-3923-1-git-send-email-panto@antoniou-consulting.com> <20121030181837.GM11908@atomide.com> <79CD15C6BA57404B839C016229A409A83EB529E4@DBDE01.ent.ti.com> In-Reply-To: <79CD15C6BA57404B839C016229A409A83EB529E4@DBDE01.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Hiremath, Vaibhav" Cc: Tony Lindgren , Pantelis Antoniou , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Koen Kooi , "Porter, Matt" , "Dill, Russ" , "linux-fbdev@vger.kernel.org" On Wed, 31 Oct 2012, Hiremath, Vaibhav wrote: > As far as lck clock node is concerned, we had deliberately dropped all leaf- > node clocks from the clock tree, please refer to the description mentioned > in - > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html Ach, should have remembered that :-( Indeed there is an LCDC hwmod: static struct omap_hwmod am33xx_lcdc_hwmod = { .name = "lcdc", .class = &am33xx_lcdc_hwmod_class, .clkdm_name = "lcdc_clkdm", .mpu_irqs = am33xx_lcdc_irqs, .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY, .main_clk = "lcd_gclk", .prcm = { .omap4 = { .clkctrl_offs = AM33XX_CM_PER_LCDC_CLKCTRL_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, }, }; > >From LCDC driver perspective, driver is using, > > fb_clk = clk_get(&device->dev, NULL); > > This I feel needs to be corrected for valid name as per Spec (mostly I would > vote for "fck") and then every platform should make sure that it returns > valid clock-node for it. > > Change in Driver would be, > > fb_clk = clk_get(&device->dev, "fck"); Indeed. - Paul