From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Sun, 09 Dec 2012 07:21:33 +0000
Subject: Re: [PATCH] drivers/video/wm8505fb.c: use devm_ functions
Message-Id: <alpine.DEB.2.02.1212090820270.2028@localhost6.localdomain6>
List-Id: <linux-fbdev.vger.kernel.org>
References: <1354984288-773-1-git-send-email-Julia.Lawall@lip6.fr>
 <1355002958.14981.11.camel@gitbox>
In-Reply-To: <1355002958.14981.11.camel@gitbox>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-arm-kernel@lists.infradead.org

> Rather than the goto, add the fail path code in directly, and return.
>
>
> ret = register_framebuffer(&fbi->fb);
> if (ret < 0) {
>  dev_err(&pdev->dev,
>  "Failed to register framebuffer device: %d\n", ret);
>  if (fbi->fb.cmap.len)
>    fb_dealloc_cmap(&fbi->fb.cmap);
>  return ret;
> }

So there is no need for the platform_set_drvdata(pdev, NULL); ?

Also, do you know if it is correct that the original code does not include
a call to dma_free_coherent?

thanks,
julia