From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Fri, 29 Mar 2013 06:21:07 +0000 Subject: Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch Message-Id: List-Id: References: <1364472270-9297-1-git-send-email-mcgrof@do-not-panic.com> <20130328083943.01e61b4b@jbarnes-desktop> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: Julia Lawall , Jesse Barnes , florianschandinat , linux-fbdev , dri-devel@lists.freedesktop.org, "backports@vger.kernel.org" , cocci@systeme.lip6.fr, "linux-kernel@vger.kernel.org" , "rodrigo.vivi" , Daniel Vetter , "rafael.j.wysocki" > > I looked in today's linux-next, and there seems to be only one > > initialization of this field, to true, and one test of this field. So > > perhaps the case for setting the field to false just isn't needed. > > Oh sorry now I get what you mean! I thought about this -- and yes I > decided to not add a bool false setting for the structure field given > that the assumption is this would not be something dynamic, and data > structure would be kzalloc()'d so by default they are 0. What do you do about the test, though? julia