From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org,
kernel test robot <lkp@intel.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
kernel-janitors@vger.kernel.org,
Bernie Thompson <bernie@plugable.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Denis Efremov <efremov@linux.com>
Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
Date: Thu, 27 Aug 2020 20:05:10 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2008272204050.2482@hadrien> (raw)
In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Thu, 27 Aug 2020, Markus Elfring wrote:
> > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> >
> > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
>
> I wonder about such a combination of information.
>
> I find it reasonable that two function implementations should be adjusted
> according to a generated patch.
> Thus I imagine that not the mentioned SmPL script is “fixed”
> but the affected source file “drivers/video/fbdev/udlfb.c” may be improved.
> Will the subject “[PATCH] video: udlfb: Fix kobj_to_dev.cocci warnings”
> (or “[PATCH] video: udlfb: Use kobj_to_dev() instead of container_of()”)
> be more appropriate for the proposed commit message?
It seems that 0-day picks up new semantic patches that are added to trees
in kernel.org, but that it's strategy for generating the patch is not
ideal. I'll just drop these Fixes lines.
julia
next parent reply other threads:[~2020-08-27 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de>
2020-08-27 20:05 ` Julia Lawall [this message]
[not found] <CGME20200826205412eucas1p16c748e9d73f4cd924aae1d6386ab450c@eucas1p1.samsung.com>
2020-08-26 20:54 ` [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Julia Lawall
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2008272204050.2482@hadrien \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=b.zolnierkie@samsung.com \
--cc=bernie@plugable.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=efremov@linux.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox