From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Simmons Date: Tue, 09 Feb 2010 19:18:00 +0000 Subject: Re: [PATCH 10/11] drivers/video/mbx: Correct NULL test Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org > From: Julia Lawall > > Test the value that was just allocated rather than the previously tested one. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @r@ > expression *x; > expression e; > identifier l; > @@ > > if (x = NULL || ...) { > ... when forall > return ...; } > ... when != goto l; > when != x = e > when != &x > *x = NULL > // > > Signed-off-by: Julia Lawall Acked-by: James Simmons > --- > drivers/video/mbx/mbxfb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c > index afea9ab..7140405 100644 > --- a/drivers/video/mbx/mbxfb.c > +++ b/drivers/video/mbx/mbxfb.c > @@ -950,7 +950,7 @@ static int __devinit mbxfb_probe(struct platform_device *dev) > > mfbi->fb_virt_addr = ioremap_nocache(mfbi->fb_phys_addr, > res_size(mfbi->fb_req)); > - if (!mfbi->reg_virt_addr) { > + if (!mfbi->fb_virt_addr) { > dev_err(&dev->dev, "failed to ioremap frame buffer\n"); > ret = -EINVAL; > goto err4; > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >