From: James Simmons <jsimmons@infradead.org>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.sf.net,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
stable@kernel.org
Subject: Re: [PATCH] fb: fix colliding defines for fb flags.
Date: Wed, 23 Jun 2010 15:58:06 +0000 [thread overview]
Message-ID: <alpine.LFD.2.00.1006231657410.7462@casper.infradead.org> (raw)
In-Reply-To: <1277257612-8491-1-git-send-email-airlied@gmail.com>
> From: Dave Airlie <airlied@redhat.com>
>
> When I added the flags I must have been using a 25 line terminal and missed the following flags.
>
> The collided with flag has one user in staging despite being in-tree for 5 years.
>
> I'm happy to push this via my drm tree unless someone really wants to do it.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Cc: stable@kernel.org
> ---
> include/linux/fb.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: James Simmons <jsimmons@infradead.org>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 907ace3..8e5a9df 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -786,8 +786,6 @@ struct fb_tile_ops {
> #define FBINFO_MISC_USEREVENT 0x10000 /* event request
> from userspace */
> #define FBINFO_MISC_TILEBLITTING 0x20000 /* use tile blitting */
> -#define FBINFO_MISC_FIRMWARE 0x40000 /* a replaceable firmware
> - inited framebuffer */
>
> /* A driver may set this flag to indicate that it does want a set_par to be
> * called every time when fbcon_switch is executed. The advantage is that with
> @@ -801,6 +799,8 @@ struct fb_tile_ops {
> */
> #define FBINFO_MISC_ALWAYS_SETPAR 0x40000
>
> +/* where the fb is a firmware driver, and can be replaced with a proper one */
> +#define FBINFO_MISC_FIRMWARE 0x80000
> /*
> * Host and GPU endianness differ.
> */
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2010-06-23 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 1:46 [PATCH] fb: fix colliding defines for fb flags Dave Airlie
2010-06-23 15:58 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006231657410.7462@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.sf.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).