From: James Simmons <jsimmons@infradead.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: linux-fbdev@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbcon: deinline large static function get_color()
Date: Wed, 23 Jun 2010 15:58:43 +0000 [thread overview]
Message-ID: <alpine.LFD.2.00.1006231658320.7462@casper.infradead.org> (raw)
In-Reply-To: <1277233556-14827-1-git-send-email-vda.linux@googlemail.com>
> This function's body is good two screenfuls and it has six callsites.
> No apparent reason why it is marked "iniline".
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/video/console/fbcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index b0a3fa0..24983e4 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
> vc->vc_mode != KD_TEXT || ops->graphics);
> }
>
> -static inline int get_color(struct vc_data *vc, struct fb_info *info,
> +static int get_color(struct vc_data *vc, struct fb_info *info,
> u16 c, int is_fg)
> {
> int depth = fb_get_color_depth(&info->var, &info->fix);
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2010-06-23 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 19:05 [PATCH] fbcon: deinline large static function get_color() Denys Vlasenko
2010-06-23 15:58 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006231658320.7462@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).