* [PATCH] fbcon: deinline large static function get_color()
@ 2010-06-22 19:05 Denys Vlasenko
2010-06-23 15:58 ` James Simmons
0 siblings, 1 reply; 2+ messages in thread
From: Denys Vlasenko @ 2010-06-22 19:05 UTC (permalink / raw)
To: linux-fbdev; +Cc: Rafael J. Wysocki, linux-kernel, Denys Vlasenko
This function's body is good two screenfuls and it has six callsites.
No apparent reason why it is marked "iniline".
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---
drivers/video/console/fbcon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index b0a3fa0..24983e4 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
vc->vc_mode != KD_TEXT || ops->graphics);
}
-static inline int get_color(struct vc_data *vc, struct fb_info *info,
+static int get_color(struct vc_data *vc, struct fb_info *info,
u16 c, int is_fg)
{
int depth = fb_get_color_depth(&info->var, &info->fix);
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fbcon: deinline large static function get_color()
2010-06-22 19:05 [PATCH] fbcon: deinline large static function get_color() Denys Vlasenko
@ 2010-06-23 15:58 ` James Simmons
0 siblings, 0 replies; 2+ messages in thread
From: James Simmons @ 2010-06-23 15:58 UTC (permalink / raw)
To: Denys Vlasenko; +Cc: linux-fbdev, Rafael J. Wysocki, linux-kernel
> This function's body is good two screenfuls and it has six callsites.
> No apparent reason why it is marked "iniline".
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/video/console/fbcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index b0a3fa0..24983e4 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
> vc->vc_mode != KD_TEXT || ops->graphics);
> }
>
> -static inline int get_color(struct vc_data *vc, struct fb_info *info,
> +static int get_color(struct vc_data *vc, struct fb_info *info,
> u16 c, int is_fg)
> {
> int depth = fb_get_color_depth(&info->var, &info->fix);
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-23 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-22 19:05 [PATCH] fbcon: deinline large static function get_color() Denys Vlasenko
2010-06-23 15:58 ` James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).