From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] add mutex to fbdev for fb_mmap locking Date: Tue, 2 Jun 2009 12:51:59 -0700 (PDT) Message-ID: References: <200905282134.n4SLYNwv027999@imap1.linux-foundation.org> <20090530121128.5f04179d.krzysztof.h1@poczta.fm> <20090531162453.dff458cb.krzysztof.h1@poczta.fm> <20090601222413.c2b57c9f.krzysztof.h1@poczta.fm> <20090602200626.1c3486e1.krzysztof.h1@poczta.fm> <20090602195240.0af2f21c@lxorguk.ukuu.org.uk> <20090602203622.244b1a74@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sfi-mx-2.v28.ch3.sourceforge.com ([172.29.28.122] helo=mx.sourceforge.net) by h25xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MBa2j-0007cK-S9 for linux-fbdev-devel@lists.sourceforge.net; Tue, 02 Jun 2009 19:53:05 +0000 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by 72vjzd1.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1MBa2g-00033a-W7 for linux-fbdev-devel@lists.sourceforge.net; Tue, 02 Jun 2009 19:53:05 +0000 In-Reply-To: <20090602203622.244b1a74@lxorguk.ukuu.org.uk> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Alan Cox Cc: krzysztof.h1@wp.pl, Linux-fbdev-devel , Peter Zijlstra , geert@linux-m68k.org, Andrew Morton , Ingo Molnar , righi.andrea@gmail.com On Tue, 2 Jun 2009, Alan Cox wrote: > > I'll fix those over the next few days to copy first, its pretty trivial > stuff Btw, it's probably best to put them in functions of their own, and make sure they are marked "noinline". Because otherwise gcc will easily inline them and because they then presumably have these "struct termios" etc as local variables, if that happens gcc will blow your stack to kingdom come. Linus ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get