From: Linus Torvalds <torvalds@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
a.p.zijlstra@chello.nl, rjw@sisk.pl, stable@kernel.org
Subject: Re: matroxfb: fix regression with uninitalized fb_info->mm_lock mutex (second head)
Date: Tue, 7 Jul 2009 13:30:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0907071327370.3210@localhost.localdomain> (raw)
In-Reply-To: <20090707223413.d56c6a7f.krzysztof.h1@poczta.fm>
On Tue, 7 Jul 2009, Krzysztof Helt wrote:
>
> Remove redundant locking by the mm_lock mutex before a second head of matrox
> framebuffer is registered.
Why do you write misleading commentary like this.
> +/*
> + * This function is called before the register_framebuffer so
> + * no locking is needed.
> + */
Or this?
It's not about "needed". The locking is not only not needed, it would be
BUGGY.
And it's not "redundant". That implies that it's done somewhere else. It's
more than "not needed" - it would be actively buggy to lock things there.
I really don't like how you're approaching this. You're ignoring the real
issues I ask you, you're writing misleading comments and commit messages,
and the end result is fragile code. I still don't understand why you
insist on initializing those things late, which is the primary problem
here.
Linus
prev parent reply other threads:[~2009-07-07 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 20:34 matroxfb: fix regression with uninitalized fb_info->mm_lock mutex (second head) Krzysztof Helt
2009-07-07 20:30 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0907071327370.3210@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox