From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Maciej W. Rozycki" Date: Sun, 22 Sep 2013 21:54:54 +0000 Subject: Re: [PATCH 2/2] framebuffer: Remove pmag-aa-fb Message-Id: List-Id: References: <6f500d88eb23fd9a4cfc5583f5ca17bc5f58fe24.1379641901.git.joe@perches.com> <1379702587.2301.12.camel@joe-AO722> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Joe Perches , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Linux Fbdev development list , "linux-kernel@vger.kernel.org" , Linux MIPS Mailing List On Sun, 22 Sep 2013, Geert Uytterhoeven wrote: > > Thanks, but the changes required are actually much more than that -- the > > driver has never been converted to the modern TURBOchannel API. I have > > now dug out an old patch I was working on back in 2006 to convert this > > driver as well as drivers/video/maxinefb.c. I'll try to complete the two > > drivers as soon as possible (unfortunately I can't test the latter at all; > > it's for an onboard graphics adapter of another DECstation model), > > although I now remember the main reason I didn't complete them back then > > was they used an old internal API that was removed and no suitable > > replacement provided. I need to investigate again what that actually was > > though (hw cursor probably). > > pmag-aa-fb.c still has struct display_switch (for the old drawing API) and the > old fb_ops (with get_var()/get_fix()), instead of the new fb_ops (rectangular > drawing API and var/fix as member data). That I got covered already in the old patch, but there was something else. Otherwise I would have pushed it along updates for pmag-ba-fb.c and pmagb-b-fb.c long ago. Maciej