* [PATCH] video: fbdev: pmag-ba-fb: Fix the lower margin size
@ 2016-02-22 1:54 Maciej W. Rozycki
2016-02-26 11:04 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2016-02-22 1:54 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: linux-fbdev, linux-kernel
According to the board specification[1] the width of the vertical sync
front porch is 12 pixels or the same as the width of the horizontal sync
front porch. This in turn means the size of the lower margin is 0,
because the vertical sync starts as soon as the start of the horizontal
sync terminates the last line.
References:
[1] "PMAG-BA TURBOchannel Color Frame Buffer Functional Specification",
Revision 1.2, Workstation Systems Engineering, Digital Equipment
Corporation, August 27, 1990, Table 3-5: "Video Timing"
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
linux-pmag-ba-lower.patch
Index: linux-20150524-4maxp64/drivers/video/fbdev/pmag-ba-fb.c
=================================--- linux-20150524-4maxp64.orig/drivers/video/fbdev/pmag-ba-fb.c
+++ linux-20150524-4maxp64/drivers/video/fbdev/pmag-ba-fb.c
@@ -60,7 +60,7 @@ static struct fb_var_screeninfo pmagbafb
.left_margin = 116,
.right_margin = 12,
.upper_margin = 34,
- .lower_margin = 12,
+ .lower_margin = 0,
.hsync_len = 128,
.vsync_len = 3,
.sync = FB_SYNC_ON_GREEN,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: pmag-ba-fb: Fix the lower margin size
2016-02-22 1:54 [PATCH] video: fbdev: pmag-ba-fb: Fix the lower margin size Maciej W. Rozycki
@ 2016-02-26 11:04 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2016-02-26 11:04 UTC (permalink / raw)
To: Maciej W. Rozycki, Jean-Christophe Plagniol-Villard
Cc: linux-fbdev, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1283 bytes --]
On 22/02/16 03:54, Maciej W. Rozycki wrote:
> According to the board specification[1] the width of the vertical sync
> front porch is 12 pixels or the same as the width of the horizontal sync
> front porch. This in turn means the size of the lower margin is 0,
> because the vertical sync starts as soon as the start of the horizontal
> sync terminates the last line.
>
> References:
>
> [1] "PMAG-BA TURBOchannel Color Frame Buffer Functional Specification",
> Revision 1.2, Workstation Systems Engineering, Digital Equipment
> Corporation, August 27, 1990, Table 3-5: "Video Timing"
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> linux-pmag-ba-lower.patch
> Index: linux-20150524-4maxp64/drivers/video/fbdev/pmag-ba-fb.c
> ===================================================================
> --- linux-20150524-4maxp64.orig/drivers/video/fbdev/pmag-ba-fb.c
> +++ linux-20150524-4maxp64/drivers/video/fbdev/pmag-ba-fb.c
> @@ -60,7 +60,7 @@ static struct fb_var_screeninfo pmagbafb
> .left_margin = 116,
> .right_margin = 12,
> .upper_margin = 34,
> - .lower_margin = 12,
> + .lower_margin = 0,
> .hsync_len = 128,
> .vsync_len = 3,
> .sync = FB_SYNC_ON_GREEN,
>
Thanks, queued for 4.6.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-26 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 1:54 [PATCH] video: fbdev: pmag-ba-fb: Fix the lower margin size Maciej W. Rozycki
2016-02-26 11:04 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).