From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Florian Fuchs <fuchsfl@gmail.com>
Cc: Helge Deller <deller@gmx.de>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] fbdev: pvr2fb: correct user pointer annotation and sentinel initializer
Date: Sat, 18 Jul 2026 23:57:40 +0200 [thread overview]
Message-ID: <alv10qYL3K8_Tjqv@monoceros> (raw)
In-Reply-To: <20260713101638.600333-1-fuchsfl@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Mon, Jul 13, 2026 at 12:16:38PM +0200, Florian Fuchs wrote:
> Add __user annotation to buf, as it is passed as a user pointer in
> pin_user_pages_fast(). Use an empty initializer for the sentinel
> board-table entry to avoid initializing a function pointer with an
> integer literal.
FTR: Using 0 in an initializer is covered by the C standard. Anyhow, I
agree that { } is nicer.
Having said that, I think the right thing to do here is to drop the
sentinel entry, because board_driver[] is only used in for loops that
iterate between 0 (inclusive) and ARRAY_SIZE(board_driver) (exclusive).
Also I would split this patch in two.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-07-18 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 10:16 [PATCH] fbdev: pvr2fb: correct user pointer annotation and sentinel initializer Florian Fuchs
2026-07-18 19:33 ` Helge Deller
2026-07-18 21:57 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alv10qYL3K8_Tjqv@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=fuchsfl@gmail.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox