From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Ömer PALA" <palaomer100@gmail.com>
Cc: Nam Cao <namcao@linutronix.de>,
andy@kernel.org, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fb_upd161704: replace udelay with usleep_range
Date: Wed, 16 Sep 2026 18:17:43 +0300 [thread overview]
Message-ID: <aqqzFxRfbxf14uld@ashevche-desk.local> (raw)
In-Reply-To: <CAKhZXnr0GdUrEu9vyMAWRCWyQzPM7cWQ6LRDa8fX0hnMkTN0RQ@mail.gmail.com>
On Wed, Sep 16, 2026 at 03:08:06PM +0300, Ömer PALA wrote:
> On Wed, Sep 16, 2026 at 12:39:28PM +0300, Andy Shevchenko wrote:
...
> Second, do you understand the difference on what
> code is doing before and after your change?
> I understand that udelay() provides deterministic, busy-wait timing required for
> hardware register initialization, whereas usleep_range() introduces scheduler
> overhead and non-deterministic delays.
> Out of technical curiosity regarding the driver IC: theoretically, if we knew
> the exact window between the hardware lock/stabilization
> time (min) and the internal state-machine timeout (max) from the datasheet,
> would a range like usleep_range(min, max) be acceptable,
> or does scheduler wake-up latency make it too risky for
> timing-critical init sequences without hardware validation?
> I will drop this patch series.
It's not only about timings, longer sleeps most likely are fine, the main
problem is atomicity.
...
Note, your reply is malformed. Choose proper tools to communicate in
the Linux kernel mailing lists.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-16 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:39 [PATCH] staging: fbtft: fb_upd161704: replace udelay with usleep_range Omer PALA
2026-09-16 9:53 ` Nam Cao
2026-09-16 11:06 ` Andy Shevchenko
2026-09-16 12:08 ` Ömer PALA
2026-09-16 12:50 ` Nam Cao
2026-09-16 13:14 ` Ömer PALA
2026-09-16 15:17 ` Andy Shevchenko [this message]
2026-09-16 11:03 ` Andy Shevchenko
[not found] <20260218180347.88034-1-tomasz.unger.ref@yahoo.pl>
2026-02-18 18:03 ` tomasz.unger
2026-02-19 7:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqqzFxRfbxf14uld@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=namcao@linutronix.de \
--cc=palaomer100@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox