Re: [PATCH] video: fbdev: simplefb: Fix info message during probe

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 12/28/20 7:39 PM, Peter Robinson wrote:
> The info message was showing the mapped address for the framebuffer. To avoid
> security problems, all virtual addresses are converted to __ptrval__, so
> the message has pointless information:
> 
> simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes, mapped to 0x(____ptrval____)
> 
> Drop the extraneous bits to clean up the message:
> 
> simple-framebuffer 3ea9b000.framebuffer: framebuffer at 0x3ea9b000, 0x12c000 bytes
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  drivers/video/fbdev/simplefb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index 533a047d07a2..62f0ded70681 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -477,9 +477,8 @@ static int simplefb_probe(struct platform_device *pdev)
>  	simplefb_clocks_enable(par, pdev);
>  	simplefb_regulators_enable(par, pdev);
>  
> -	dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n",
> -			     info->fix.smem_start, info->fix.smem_len,
> -			     info->screen_base);
> +	dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes\n",
> +			     info->fix.smem_start, info->fix.smem_len);
>  	dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
>  			     params.format->name,
>  			     info->var.xres, info->var.yres,
>