From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBDCC433FE for ; Mon, 14 Nov 2022 07:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235493AbiKNH1K (ORCPT ); Mon, 14 Nov 2022 02:27:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235415AbiKNH1I (ORCPT ); Mon, 14 Nov 2022 02:27:08 -0500 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F29D2F4 for ; Sun, 13 Nov 2022 23:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1668410809; bh=03wLu49cZv64GpemsqyWTBRjGEW6O/JGrtvIRDD80Eo=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=CfZ0aajqcuOfOhbOmAFNTe1bJks+CDNzf/Wf/FVM/djktXA7XWQGiQlDGq4a8i834 dLMVNDcGuhfVezfl4FcH0K5QrWYbOlHZx1FowLBRyyFG0Pvv05xDY9BFX5xGtWaehX m3LzrUVde5XRuPmGIpQZpiXM9oCmSoeugP8PTRrsOIx6qI9X15yiplZMfEH4Y9GVZ4 CUEYcvl1TmMtkaz5YgGVbgG3IfX7gArV1C9+XI/8UeJRCkHBlIdts6aGxJczOLP7M7 iDN2G9Yz2Kv1ThjlniFHJnCUytYoNOTDn7LdrXyiBxbVV9WIZX5pY8OCoOmpZwEjW4 nDC9UBNODYBag== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([92.116.133.36]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MUGi9-1oUFty3PTH-00REWD; Mon, 14 Nov 2022 08:26:49 +0100 Message-ID: Date: Mon, 14 Nov 2022 08:26:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] video: fbdev: via: Fix error in via_core_init() To: Shang XiaoJing , FlorianSchandinat@gmx.de, corbet@lwn.net, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20221114010852.24654-1-shangxiaojing@huawei.com> Content-Language: en-US From: Helge Deller In-Reply-To: <20221114010852.24654-1-shangxiaojing@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sinvKU42+4Q97BLFIhtATFJzrZSQwk71g9NpLVmFpItcLrbOkAK EOs3VJ6B7LBXDEjh3G1KpGpYr9ULAjqKep61ceTg8uhwEnXceikgZ27r6/nH4NzGtLPANR4 PSiKNQK3SLcEpLJFGFya5Z4KgJLJjXAhhdlH/Lt+PX2Mm3oCnrgFpgbkvGhgTvxDlkOk1IQ sBwL3zemDLZo9xRmRP3nw== UI-OutboundReport: notjunk:1;M01:P0:SJm7yKAmtxg=;gb/FquGyS/lpbi+idyOsHycdixW rHJGMuw9rze5UA4Iqu5iBVM4xGau16uHupW6CAhRT2+IBOStcMD58JYgNh/mh1fahMc5FL6G5 eigQq4YCXWrdJN5H2W5YT9geesGyUBC7Kaoyayw4g51XNJzvc11xD9TxUY90alDnDUIYh+jrQ uG7BMgufXz82NK69VE5+pzQmVk4EmR/Gj8ZHdJIFjmO4VYHqVAjDbUrNxJ6Q9e55FCln3feqj TBgvBlxI6KGcktrVx985y4DIEJUrlfkKDSfaGo6A/zcV3aO3hRGsm1TL+UwVX/L0ylRWPIZ8a Zsib380BpsRhZe5w+17umKGWOb2HxEy0f5jaBl0QCOuLxjsakbIxhdjxtonGNtT7RuV5TCVud Mykk0ezjiVRi+pUjxNIlSccT0zLacacBll5dUVrVblvhv+SXfiCg6UDGPJwYARlf6lds1UDA8 EAQpW/b6FUlodtej4CS8NQe+9buQ6jFRNN4BrZlIMd+WCsryZHDn1xKw32o28ZDSjGXUXpZ2X vBtobPoVc4miFHp7QNrvY6NUnxEXt9+W6c0/6zdRX5A7C9ZAL/cCNNn0Yp9j+2gHv1HFuLYJM loT88IB6cez3nFt1cwRDVRW4K7EU9KkoYwPpjk2NpfDEURvYcs8tjShI9pGZGLwcyGdfCIgsd AhAgoaU2HbHtTOAe8pRDuWPXKi+PFtmmHqRqIchB1do/u5lEfKTK1VAwR5lOrbIGWPlc+ru5V Fj1Elahfek0NtDIO7WiJMP+kuKQNhWUrx7D1u75cIs1C/gca642v4zP5PQBNrJejpjZLiPxKH qBfcgzMUUBEdKoPVA5rba7Tq7x1AQaJ61tL2MboWna042epewHSoiokQaoOQAhcr9w0tMTcMW 9oBv+pvKTRb/m5M1HWL8JHmA/z2dO1ThjogxtQkfpvpo8NHcWet+ZvmB/xfRV/T7AGQ2uYJDE A57DwA== Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 11/14/22 02:08, Shang XiaoJing wrote: > via_core_init() won't exit the driver when pci_register_driver() failed. > Exit the viafb-i2c and the viafb-gpio in failed path to prevent error. > > VIA Graphics Integration Chipset framebuffer 2.4 initializing > Error: Driver 'viafb-i2c' is already registered, aborting... > Error: Driver 'viafb-gpio' is already registered, aborting... > > Fixes: 7582eb9be85f ("viafb: Turn GPIO and i2c into proper platform devi= ces") > Signed-off-by: Shang XiaoJing applied. Thanks! Helge > --- > drivers/video/fbdev/via/via-core.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/via/via-core.c b/drivers/video/fbdev/vi= a/via-core.c > index 2ee8fcae08df..b2e3b5df38cd 100644 > --- a/drivers/video/fbdev/via/via-core.c > +++ b/drivers/video/fbdev/via/via-core.c > @@ -730,7 +730,15 @@ static int __init via_core_init(void) > return ret; > viafb_i2c_init(); > viafb_gpio_init(); > - return pci_register_driver(&via_driver); > + ret =3D pci_register_driver(&via_driver); > + if (ret) { > + viafb_gpio_exit(); > + viafb_i2c_exit(); > + viafb_exit(); > + return ret; > + } > + > + return 0; > } > > static void __exit via_core_exit(void)