From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC95EB64DD for ; Thu, 29 Jun 2023 13:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231269AbjF2NDr (ORCPT ); Thu, 29 Jun 2023 09:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjF2NDq (ORCPT ); Thu, 29 Jun 2023 09:03:46 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 550722D52; Thu, 29 Jun 2023 06:03:45 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 66FAB3200645; Thu, 29 Jun 2023 09:03:43 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 29 Jun 2023 09:03:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1688043823; x=1688130223; bh=UU HaYOR2mXOloOMHF3WLMCOR1A2U5vkl9suJPqtiWo0=; b=MrZKZHz8n89eIUCcId WXghgyhn+F5Y91JfHNG7h6bRVjajE8fTPAAhjd5yTneIb4wXSmpq1LbKXeSmewdI sjdK3BzECiJ9VsNHc2PNHRoZhm3xRYAm+niXcO3LaQQU4MhSkHRgNL7KekTbhGST XCtAL/9vFB8aEMmwPzbk/lKYaOw3o3ta7pbwYVJoUl4935nDF9T6MZnBnxl2NyE7 45XG/pQFMaOjg4FsJiuQ0OJjKw2rT3OTyLreg4EK69iWblkKDeRqN9hM0nHAreco 4RI2C7HjAM7m3bAIxsusNPU7K1/tqKHlRAu78xIkM/MvkFfL8/VzpTp9irh6eiv1 BUyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688043823; x=1688130223; bh=UUHaYOR2mXOlo OMHF3WLMCOR1A2U5vkl9suJPqtiWo0=; b=cw+4bxWp1SCuh1Fepi9QaF0if2xkJ 4cVNwE6L2Y8B0BZ4j9mhs/w9CTABQ9uk/lLli7KdPcxXX5GNTfzwwEySah2SpLb8 3Aufg0geWX/HnfgPaOANO2QzCTk7sUuxlOKDej+fIqwnaRnTlWOjf1PvCQRQ1mQ0 CXujhLdJDB5jYKlNYIPiNMNvbVyuShIxf7Z2hPXbTAnwB8HTZUAxnS+3doFVCZfS gmb4I1VMLKW5DeH4sul6m4UUqvsEZj5uqrhNhN+sCrKAZmp5/84QBsLfhkM2pVjK QvJS+nuvgBir+CxBeaUMXNbGK4UqHWvJ/CRH9X+edp1kdt3CdxMbNaTXQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeggdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 688DEB60086; Thu, 29 Jun 2023 09:03:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230629121952.10559-7-tzimmermann@suse.de> References: <20230629121952.10559-1-tzimmermann@suse.de> <20230629121952.10559-7-tzimmermann@suse.de> Date: Thu, 29 Jun 2023 15:03:20 +0200 From: "Arnd Bergmann" To: "Thomas Zimmermann" , "Helge Deller" , "Daniel Vetter" , "Dave Airlie" Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, "linux-csky@vger.kernel.org" , linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, Linux-Arch , "Richard Henderson" , "Ivan Kokshaysky" , "Matt Turner" , "Russell King" , "Catalin Marinas" , "Will Deacon" , guoren , "Brian Cain" , "Huacai Chen" , "WANG Xuerui" , "Thomas Bogendoerfer" , "Dinh Nguyen" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Chris Zankel" , "Max Filippov" , "Kees Cook" , "Paul E. McKenney" , "Peter Zijlstra" , "Frederic Weisbecker" , "Andrew Morton" , "Ard Biesheuvel" , "Sami Tolvanen" , "Juerg Haefliger" , "Geert Uytterhoeven" , "Anshuman Khandual" , "Niklas Schnelle" , "Russell King" , "Linus Walleij" , "Sebastian Reichel" , "Mike Rapoport" , "Kirill A. Shutemov" , "Zi Yan" Subject: Re: [PATCH 06/12] arch: Declare screen_info in Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > diff --git a/include/asm-generic/screen_info.h > b/include/asm-generic/screen_info.h > new file mode 100644 > index 0000000000000..6fd0e50fabfcd > --- /dev/null > +++ b/include/asm-generic/screen_info.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _ASM_GENERIC_SCREEN_INFO_H > +#define _ASM_GENERIC_SCREEN_INFO_H > + > +#include > + > +#if defined(CONFIG_ARCH_HAS_SCREEN_INFO) > +extern struct screen_info screen_info; > +#endif > + > +#endif /* _ASM_GENERIC_SCREEN_INFO_H */ > diff --git a/include/linux/screen_info.h b/include/linux/screen_info.h > index eab7081392d50..c764b9a51c24b 100644 > --- a/include/linux/screen_info.h > +++ b/include/linux/screen_info.h > @@ -4,6 +4,6 @@ > > #include > > -extern struct screen_info screen_info; > +#include > What is the purpose of adding a file in asm-generic? If all architectures use the same generic file, I'd just leave the declaration in include/linux/. I wouldn't bother adding the #ifdef either, but I can see how that helps turn a link error into an earlier compile error. Arnd