From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Mon, 13 Nov 2017 13:55:25 +0000 Subject: Re: [PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup Message-Id: List-Id: References: <20171113102049.9342-1-johan@kernel.org> <20171113102049.9342-3-johan@kernel.org> In-Reply-To: <20171113102049.9342-3-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johan Hovold , Lee Jones Cc: linux-fbdev@vger.kernel.org, Jingoo Han , linux-kernel@vger.kernel.org, stable , dri-devel@lists.freedesktop.org, Matthias Kaehlcke On 13/11/17 10:20, Johan Hovold wrote: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at the parent rather than just matching > on its children. > > This would only cause trouble if the child node is missing while there > is an unrelated node named "backlight" elsewhere in the tree. > > Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver") > Cc: stable # 3.7 > Cc: Matthias Kaehlcke > Signed-off-by: Johan Hovold Acked-by: Daniel Thompson > --- > drivers/video/backlight/tps65217_bl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c > index 380917c86276..762e3feed097 100644 > --- a/drivers/video/backlight/tps65217_bl.c > +++ b/drivers/video/backlight/tps65217_bl.c > @@ -184,11 +184,11 @@ static struct tps65217_bl_pdata * > tps65217_bl_parse_dt(struct platform_device *pdev) > { > struct tps65217 *tps = dev_get_drvdata(pdev->dev.parent); > - struct device_node *node = of_node_get(tps->dev->of_node); > + struct device_node *node; > struct tps65217_bl_pdata *pdata, *err; > u32 val; > > - node = of_find_node_by_name(node, "backlight"); > + node = of_get_child_by_name(tps->dev->of_node, "backlight"); > if (!node) > return ERR_PTR(-ENODEV); > >