linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ung <davidu@nvidia.com>
To: linux-fbdev@vger.kernel.org
Subject: RE: [PATCH] video: fbdev: Add CVT timing calculations.
Date: Thu, 20 Nov 2014 21:00:39 +0000	[thread overview]
Message-ID: <b8529a8473ec4a69994ac85d7766ba13@HQMAIL102.nvidia.com> (raw)
In-Reply-To: <1415746455-28701-1-git-send-email-davidu@nvidia.com>

> On 12/11/14 00:54, David Ung wrote:
> > Currently fbmon is still relying on the old GTF timings when parsing
> > the standard timings of the EDID.
> > This causes problem with some monitor eg DELL U2410 which advertises
> > high resolutions like 1920x1200@60 and GTF timing gives it 193mhz
> > clock which is out of spec of the monitor which has dclkmax of 170mhz.
> > This patch address the above problem by adding support for CVT with
> > reduced timings.
> 
> These timings are quite complex, and I don't claim to fully understand all
> the details, so I have a few questions:
> 
> So you say the monitor has a standard timing for 1920x1200@60. If I read the
> EDID standard right, a standard timing entry either has to match a timing
> from VESA DMT, or it shall be calculated using GTF.
> 
> Don't we have or shouldn't we have a table for the VESA DMT modes, from
> which to search for standard timings? 1920x1200@60 should be found there.

Agree, there ought to be a DMT table of modes that it should match against, though this table does not exist currently in fbdev.
After reading your comment, I had a look at the edid again for DELL U2410 and in the standard timing, it defines - (D1, 00)h
According to the DMT document, that matches DMT ID 45h - which the table defines as 193.25mhz pixel clock.

Clearly my patch is wrong in this approach which tries to correct the problem with cvt reduce timing.
The correct approach should be to invalidate this mode since the monspec defines a max clock of 170mhz.

This should make the patch much more simpler.  I shall abandon this patch and post a different one.

David


      parent reply	other threads:[~2014-11-20 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 22:54 [PATCH] video: fbdev: Add CVT timing calculations David Ung
2014-11-18 23:40 ` David Ung
2014-11-20 12:51 ` Tomi Valkeinen
2014-11-20 21:00 ` David Ung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8529a8473ec4a69994ac85d7766ba13@HQMAIL102.nvidia.com \
    --to=davidu@nvidia.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).