From: Helge Deller <deller@gmx.de>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-fbdev@vger.kernel.org, "Rob Clark" <robdclark@gmail.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: Update fbdev source file paths
Date: Thu, 31 Aug 2023 23:49:47 +0200 [thread overview]
Message-ID: <b8a04a40-a8ad-16ef-fdde-e56acb6845ca@gmx.de> (raw)
In-Reply-To: <d0646771-d426-45c6-e189-517b1e6e6248@gmx.de>
On 8/31/23 11:02, Helge Deller wrote:
> On 8/31/23 10:51, Daniel Vetter wrote:
>> On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote:
>>> On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote:
>>>> Hi
>>>>
>>>> Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer:
>>>>> The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and
>>>>> fbcmap.c were moved to drivers/video/fbdev, and subsequently to
>>>>> drivers/video/fbdev/core, in the commits listed below.
>>>>>
>>>>> Reported by kalekale in #kernel (Libera IRC).
>>>>>
>>>>> Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
>>>>> Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory")
>>>>> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>>>>
>>>> IMHO these comments might just be removed.
>>>
>>> I think it's nice to have some sort of visual separation between groups
>>> of functions in fb.h, which these comments provide at the moment.
>>> Therefore I'm currently leaning towards my patch as it is, but I'm
>>> willing to have my mind changed and do a v2 which just removes the
>>> comments.
>>
>> Just the filename without the full path maybe?
>
> Yes, I'd prefer that as well.
I've manually changed it and applied the patch to the fbdev git tree.
Thanks!
Helge
next prev parent reply other threads:[~2023-08-31 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 20:02 [PATCH] fbdev: Update fbdev source file paths Jonathan Neuschäfer
2023-08-30 7:10 ` Thomas Zimmermann
2023-08-31 6:44 ` Jonathan Neuschäfer
2023-08-31 8:51 ` Daniel Vetter
2023-08-31 9:02 ` Helge Deller
2023-08-31 21:49 ` Helge Deller [this message]
2023-09-01 17:19 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a04a40-a8ad-16ef-fdde-e56acb6845ca@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=j.neuschaefer@gmx.net \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).